From: Sergey Belyashov <sergey.belyashov@gmail.com>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb] Add Z80 CPU basic support
Date: Thu, 24 Sep 2020 18:21:46 +0300 [thread overview]
Message-ID: <CAOe0RDzRDReZLP51FGZa3o=e3=+_sYpViPv+5h+tM1JgN4S2_A@mail.gmail.com> (raw)
In-Reply-To: <34795027-0954-e286-dc1a-1f810a8ff6e1@simark.ca>
чт, 24 сент. 2020 г. в 17:08, Simon Marchi <simark@simark.ca>:
>
> Thanks, I was able to apply it successfully. It doesn't build, however,
> please make sure it builds against the current master.
Yes, you are right. I was surprised too. Fixed patch will be in the next email.
> Some questions:
>
> - What's the history behind this code? Is is currently maintained
> somewhere else? Do you own it all? In order to push that code (and
> transfer the copyright to the FSF), everybody who currently owns it
> must have an assignment on file, normally.
This code is written by me from scratch. Some code parts are copied from
other GDB source files.
> - How do you test this? How can I test this? Add this to the commit
> message.
I have tested it on my embedded device.
> - Did you manage to run parts of the GDB testsuite against this?
GDB testsuit cannot be used, because there are no GCC port to Z80.
> - If I want more information about the Z80 architecture, such as the ISA
> details, ABI, etc, where do I look? It would also be a good idea to
> add this to the commit message.
It can be downloaded on Zilog offical site.
> - I see mention of "eZ80". Can you provide information about what CPUs
> are supported, what CPUs are not supported? Include any relevant
> detail like that in the commit message.
eZ80 in Z80 mode is supported. I have no device with eZ80 working in ADL mode.
> We want to avoid people dropping code and then leaving a maintenance
> burden to others. Ideally, each architecture should have a maintainer
> (listed in the MAINTAINERS file) responsible for reviewing patches about
> that architecture, and to whom we can reach out for questions about that
> architecture. Would you be ready to accept such a role?
Yes, I'm ready.
> Shouldn't there be two different target descriptions for Z80 and eZ80?
I have not completely supported the eZ80 in ADL mode, so I do not provide
a description for it. In legacy Z80 mode eZ80 has the same registers and
flags as Z80/Z180.
> > diff --git a/gdb/stubs/z80-stub.c b/gdb/stubs/z80-stub.c
> > new file mode 100644
> > index 0000000000..36316b95ba
> > --- /dev/null
> > +++ b/gdb/stubs/z80-stub.c
>
> What is this file for? How do I use it?
This file is used as an embedded debugger monitor. Currently GDB is
tested with it.
Best regards,
Sergey Belyashov
next prev parent reply other threads:[~2020-09-24 15:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 9:21 [PATCH] Add Zilog Z80 CPU (and derivatives) support Sergey Belyashov
2020-09-24 2:55 ` Simon Marchi
2020-09-24 2:57 ` Simon Marchi
2020-09-24 8:26 ` [PATCH] [gdb] Add Z80 CPU basic support sergey.belyashov
2020-09-24 14:08 ` Simon Marchi
2020-09-24 15:21 ` Sergey Belyashov [this message]
2020-09-24 15:42 ` Simon Marchi
2020-09-24 15:22 ` [PATCH v3] " Sergey Belyashov
2020-09-24 15:44 ` Simon Marchi
2020-09-25 11:40 ` [PATCH v4] [gdb] Add basic Z80 CPU support Sergey Belyashov
2020-10-06 10:17 ` Sergey Belyashov
2020-10-07 3:07 ` Simon Marchi
2021-05-24 19:13 ` Joel Brobecker
2021-07-12 21:37 ` Simon Marchi
2021-07-13 5:42 ` Sergey Belyashov
2021-07-13 13:01 ` Simon Marchi
2021-07-13 13:28 ` Sergey Belyashov
2021-07-15 2:23 ` Simon Marchi
2021-07-15 2:29 ` [PATCH v5] " Simon Marchi
2021-07-15 7:19 ` Sergey Belyashov
2020-09-25 12:40 ` [PATCH v3] [gdb] Add Z80 CPU basic support Sergey Belyashov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOe0RDzRDReZLP51FGZa3o=e3=+_sYpViPv+5h+tM1JgN4S2_A@mail.gmail.com' \
--to=sergey.belyashov@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).