public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Reuben Thomas <rrt@sc3d.org>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/doc] Fix to manual for description of remote protocol
Date: Wed, 22 Jul 2020 14:58:54 +0100	[thread overview]
Message-ID: <CAOnWdogAqB_zsEAooPA2tReQaucVQCxQJ-zZ8tBR74p6wm4hFA@mail.gmail.com> (raw)
In-Reply-To: <5fbf55a9-2fe9-6018-79d5-7bcedf547f2f@palves.net>

On Wed, 22 Jul 2020 at 14:56, Pedro Alves <pedro@palves.net> wrote:

Thanks very much for the review!

Note this should go to the gdb/doc/ChangeLog file instead.
>

Apologies, I didn't see that file existed.

I see you're dropping the reference to the s (step) command.
> However, either "s" or "vCont;s" _are_ mandatory if the target supports
> hardware single-step.  E.g. an x86 stub that doesn't implement
> s or vCont;s won't work.


Thanks for the correction.

The choice of whether to require s is a little more complicated
> than that, but I don't think we need to go into too much detail here.
>
> Do you think the version below is clear enough?
>

That looks great to me.

-- 
https://rrt.sc3d.org

  reply	other threads:[~2020-07-22 13:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 19:14 Reuben Thomas
2020-07-22 13:56 ` Pedro Alves
2020-07-22 13:58   ` Reuben Thomas [this message]
2020-07-22 15:17     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOnWdogAqB_zsEAooPA2tReQaucVQCxQJ-zZ8tBR74p6wm4hFA@mail.gmail.com \
    --to=rrt@sc3d.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).