From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id E7B1E385700B for ; Wed, 22 Jul 2020 13:59:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E7B1E385700B Received: by mail-ot1-x335.google.com with SMTP id g37so1788357otb.9 for ; Wed, 22 Jul 2020 06:59:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KFdrSyBRjZUVy685OtV/Ph2ALFlfdAgykjUlFMqpGR0=; b=GUANNuMShCqpZkbmkV2W6/JLZCpXUa1E8CXGj7ZSY2u0+QOjK/yoI47F8MY39nR64C LfvG920m+AQGcXKvGVSiVG2nPCZosmpSykTSQx5xI0H290DxmC0hnOEJHN3uE2wvtEVV OrsrH+/rf/IyAZITZ3lLctvlJQhDECGa01oMjn1e/YAj46UgKseyzfqSK8IZ6k1Btj7P PFl1VN+T8Us8twX/XZoDTwyNbUAm2Nxr10Yuz3YEpV1SbhZpC6nUOzVj3T214TIxxuDn yWZqcRz0YptVuXbq0n0mndIPBgcaEKVmz7aLZ06NJfJsZbxXSjkw2uE3C74NLDFikxcY gtew== X-Gm-Message-State: AOAM530ed2ASyw2zmz4acY1wShxRSuWKFNOf9VwKD8ycj+N4+WiUE+Nk PfDDIiz/hcRn+IyPqplLcpuh13Umxq0r3zCsqsqg3goK X-Google-Smtp-Source: ABdhPJyO8a+Yk1VZw+h8AW6MiN31nLQTeint8h/wS+PI5FvnmewZnJ+sjiyZKUFG/SoqCun0ec2bj6E4SaQaxQksS28= X-Received: by 2002:a9d:6c54:: with SMTP id g20mr122021otq.120.1595426345277; Wed, 22 Jul 2020 06:59:05 -0700 (PDT) MIME-Version: 1.0 References: <5fbf55a9-2fe9-6018-79d5-7bcedf547f2f@palves.net> In-Reply-To: <5fbf55a9-2fe9-6018-79d5-7bcedf547f2f@palves.net> From: Reuben Thomas Date: Wed, 22 Jul 2020 14:58:54 +0100 Message-ID: Subject: Re: [PATCH][gdb/doc] Fix to manual for description of remote protocol To: Pedro Alves Cc: gdb-patches@sourceware.org X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 13:59:07 -0000 On Wed, 22 Jul 2020 at 14:56, Pedro Alves wrote: Thanks very much for the review! Note this should go to the gdb/doc/ChangeLog file instead. > Apologies, I didn't see that file existed. I see you're dropping the reference to the s (step) command. > However, either "s" or "vCont;s" _are_ mandatory if the target supports > hardware single-step. E.g. an x86 stub that doesn't implement > s or vCont;s won't work. Thanks for the correction. The choice of whether to require s is a little more complicated > than that, but I don't think we need to go into too much detail here. > > Do you think the version below is clear enough? > That looks great to me. -- https://rrt.sc3d.org