From: Pip Cet <pipcet@gmail.com>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] WebAssembly: Disable subdirectory configuration for unsupported LD
Date: Sun, 04 Feb 2018 14:53:00 -0000 [thread overview]
Message-ID: <CAOqdjBcD8+nsbPnEB95bZGQ9qnJPsu-FjeRipah7_vVz+pnozA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1802030457060.3553@tp.orcam.me.uk>
Hello Maciej,
thank you for looking at this code! The change looks obviously correct to me.
Regards
Pip
On Sat, Feb 3, 2018 at 3:16 PM, Maciej W. Rozycki <macro@mips.com> wrote:
> Remove an LD subdirectory configuration error:
>
> *** ld does not support target wasm32-unknown-none
> *** see ld/configure.tgt for supported targets
> make[1]: *** [configure-ld] Error 1
>
> which prevents binutils for the WebAssembly target from being built
> unless an explicit `--disable-ld' configuration option has been given.
> Users must not have to disable features selected by default to get a
> working configuration.
>
> /
> * configure.ac <wasm32-*-*> (noconfigdirs): Add `ld'.
> * configure: Regenerate.
> ---
> Hi,
>
> It should be obvious. Also this causes troubles with cross-target
> testing. OK to apply?
>
> Maciej
> ---
> configure | 3 +++
> configure.ac | 3 +++
> 2 files changed, 6 insertions(+)
>
> binutils-wasm32-no-ld.diff
> Index: binutils/configure
> ===================================================================
> --- binutils.orig/configure 2018-01-28 00:48:43.000000000 +0000
> +++ binutils/configure 2018-02-02 05:48:19.239569799 +0000
> @@ -3860,6 +3860,9 @@ case "${target}" in
> vax-*-*)
> noconfigdirs="$noconfigdirs target-newlib target-libgloss"
> ;;
> + wasm32-*-*)
> + noconfigdirs="$noconfigdirs ld"
> + ;;
> esac
>
> # If we aren't building newlib, then don't build libgloss, since libgloss
> Index: binutils/configure.ac
> ===================================================================
> --- binutils.orig/configure.ac 2018-01-28 00:48:43.000000000 +0000
> +++ binutils/configure.ac 2018-02-02 05:48:09.444938712 +0000
> @@ -1191,6 +1191,9 @@ case "${target}" in
> vax-*-*)
> noconfigdirs="$noconfigdirs target-newlib target-libgloss"
> ;;
> + wasm32-*-*)
> + noconfigdirs="$noconfigdirs ld"
> + ;;
> esac
>
> # If we aren't building newlib, then don't build libgloss, since libgloss
next prev parent reply other threads:[~2018-02-04 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-03 18:52 Maciej W. Rozycki
2018-02-04 14:53 ` Pip Cet [this message]
2018-02-13 13:42 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOqdjBcD8+nsbPnEB95bZGQ9qnJPsu-FjeRipah7_vVz+pnozA@mail.gmail.com \
--to=pipcet@gmail.com \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=macro@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).