From: Doug Evans <xdje42@gmail.com>
To: Yao Qi <yao@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFC] Run tests in sub dir of testsuite/
Date: Thu, 11 Dec 2014 03:06:00 -0000 [thread overview]
Message-ID: <CAP9bCMQGOfN_YydJY2o5NJkAtZH5ZduWYzAH++FHjFpdcZC8NA@mail.gmail.com> (raw)
In-Reply-To: <1418266428-13166-1-git-send-email-yao@codesourcery.com>
On Wed, Dec 10, 2014 at 6:53 PM, Yao Qi <yao@codesourcery.com> wrote:
> This patch is to run testsuite in a subdirectory of testsuite/, in
> order to facilitate 'make clean'. In sequential testing, directory
> testsuite/sequential-tests is created, and in parallel testing,
> directory testsuite/parallel-tests is created. Testing artifacts
> (such as directory gdb.base, gdb.ada, object files, shared libraries
> and executables) are stored in it.
>
> In testsuite/Makefile.in, we set OUTPUTDIR to either sequential-tests
> or parallel-tests, determined by whether we run tests in parallel.
> Makefile passes OUTPUTDIR to dejagnu, and lib/gdb.exp return the
> expected file path according to OUTPUTDIR.
>
> This patch changes the location of gdb.sum, so some build/test scripts
> are affected.
>
> gdb/testsuite:
>
> 2014-12-11 Yao Qi <yao@codesourcery.com>
>
> * Makefile.in: Set OUTPUTDIR.
> (check-single): Create dir OUTPUTDIR and pass $(OUTPUTDIR) to
> runtest.
> (check-parallel): Use $(OUTPUTDIR).
> (check/%.exp): Pass $(OUTPUTDIR) to runtest.
> (check-perf): Likewise.
> (clean): Remove directory sequential-tests and parallel-tests.
> * lib/gdb.exp (standard_output_file): Return file path name
> according to new directory structure.
> (gdb_init): Use $OUTPUTDIR instead of outputs.
> (top-level): Create directory $OUTPUTDIR.
> * lib/trace-support.exp (get_in_proc_agent): Don't use $objdir
> in the path of inprocagent.
> * gdb.base/completion.exp: Use ${OUTPUTDIR}.
> * gdb.base/hashline1.exp: Use [pwd] instead of $objdir.
Hi.
I can't review the patch right now, but I have a question.
Is there intended to be a followup patch to remove
all the makefiles in testsuite/ except testsuite/Makefile.in?
[I realize this patch is just RFC.
I just want to understand where this is headed.]
btw, while it might be cleaner to move gdb.log,gdb.sum into
the subdirs, it's not necessary.
I can update my build scripts, but if we're going
to be affecting a lot of build scripts then I'd
reconsider.
next prev parent reply other threads:[~2014-12-11 3:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 2:54 Yao Qi
2014-12-11 3:06 ` Doug Evans [this message]
2014-12-11 3:18 ` Yao Qi
2014-12-12 11:35 ` Pedro Alves
2014-12-14 6:12 ` Yao Qi
2014-12-25 2:46 ` Yao Qi
2015-01-11 12:36 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP9bCMQGOfN_YydJY2o5NJkAtZH5ZduWYzAH++FHjFpdcZC8NA@mail.gmail.com \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).