From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 793 invoked by alias); 18 Jan 2014 20:16:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 784 invoked by uid 89); 18 Jan 2014 20:16:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f53.google.com Received: from mail-wg0-f53.google.com (HELO mail-wg0-f53.google.com) (74.125.82.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 18 Jan 2014 20:16:57 +0000 Received: by mail-wg0-f53.google.com with SMTP id y10so5615669wgg.8 for ; Sat, 18 Jan 2014 12:16:54 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.194.77.7 with SMTP id o7mr7564896wjw.35.1390076214009; Sat, 18 Jan 2014 12:16:54 -0800 (PST) Received: by 10.194.17.104 with HTTP; Sat, 18 Jan 2014 12:16:53 -0800 (PST) In-Reply-To: <87sit4kb1t.fsf@gnu.org> References: <52b9da59.64ab440a.0b0b.7e1c@mx.google.com> <83ha9w68av.fsf@gnu.org> <87sit4kb1t.fsf@gnu.org> Date: Sat, 18 Jan 2014 20:16:00 -0000 Message-ID: Subject: Re: [PATCH v1 02/36] Guile extension language: doc additions From: Doug Evans To: =?ISO-8859-1?Q?Ludovic_Court=E8s?= , Eli Zaretskii Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00700.txt.bz2 On Fri, Jan 3, 2014 at 1:30 PM, Ludovic Court=E8s wrote: >>> +The optional @var{errors} argument is either @code{"strict"} >>> +or @code{"replace"}. A value of @code{"strict"} corresponds to >>> +Guile's @code{SCM_FAILED_CONVERSION_ERROR} and a value of @code{"repla= ce"} >>> +corresponds to Guile's @code{SCM_FAILED_CONVERSION_QUESTION_MARK}. >> >> Suggest a cross-reference to Guile documentation here. > > Agreed. Also, Guile talks of =93conversion strategy=94 and =93conversion > error handler=94, with values =91error=92, =91substitute=92, and =91escap= e=92 (at the > Scheme level), and I=92d recommend sticking to those names and terminolog= y. The values chosen were to be consistent with the python support. OTOH I *do* like being more consistent with the particular extension language at hand. I've tentatively changes things to use "error" and "substitute". Question: How about exporting the SCM_FAILED_CONVERSION_* constants and using those instead? E.g, (value->string foo #:errors SCM_FAILED_CONVERSION_ERROR) ? I don't have a strong opinion either way. Also, in the same spirit of naming things with preference to being more consistent with the extension language at hand than being more consistent across all extension languages, does anyone mind if I rename the "guile-interactive" command to "guile-repl"?