From: Doug Evans <xdje42@gmail.com>
To: "Wiederhake, Tim" <tim.wiederhake@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Metzger, Markus T" <markus.t.metzger@intel.com>,
"palves@redhat.com" <palves@redhat.com>
Subject: Re: [PATCH v6 0/9] Python bindings for btrace recordings
Date: Tue, 14 Feb 2017 16:22:00 -0000 [thread overview]
Message-ID: <CAP9bCMQbxHFJEggtnzNUZ-_JhUtifMq8s-Fva33heR6=CLZ7cw@mail.gmail.com> (raw)
In-Reply-To: <9676A094AF46E14E8265E7A3F4CCE9AF94021F@irsmsx105.ger.corp.intel.com>
On Tue, Feb 14, 2017 at 2:18 AM, Wiederhake, Tim
<tim.wiederhake@intel.com> wrote:
> Hi all,
>
>> > Is this good to go?
>> LGTM
>
> ... And in return I made a mess. What should have been a "git push --dry-run" to prepare for pushing this, ended up as an actual push. The commits now miss the actual ChangeLog entries and contain some "Change-Id" lines. Before I start fiddeling and probably make things worse, could you tell me how to properly resolve this?
>
> Thanks,
> Tim
Hi.
I suppose technically the Right thing to do is to revert it all and
recommit with the ChangeLog changes.
But it's not like we never make post-commit corrections to just ChangeLogs.
Perhaps not on this scale, but I'm totally ok with just ignoring the
Change-Id lines and adding the ChangeLog entries as a separate patch.
next prev parent reply other threads:[~2017-02-14 16:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 12:38 Tim Wiederhake
2017-02-13 12:38 ` [PATCH v6 1/9] btrace: Count gaps as one instruction explicitly Tim Wiederhake
2017-02-13 12:38 ` [PATCH v6 5/9] Add method to query current recording method to target_ops Tim Wiederhake
2017-02-13 12:38 ` [PATCH v6 9/9] Add documentation for new record Python bindings Tim Wiederhake
2017-02-13 14:48 ` Eli Zaretskii
2017-03-03 11:10 ` Yao Qi
2017-03-06 8:56 ` Wiederhake, Tim
2017-03-07 11:53 ` Yao Qi
2017-03-07 17:23 ` Wiederhake, Tim
2017-03-17 16:50 ` Yao Qi
2017-02-13 12:38 ` [PATCH v6 3/9] btrace: Use binary search to find instruction Tim Wiederhake
2017-02-13 12:38 ` [PATCH v6 2/9] btrace: Export btrace_decode_error function Tim Wiederhake
2017-02-13 12:38 ` [PATCH v6 4/9] Add record_start and record_stop functions Tim Wiederhake
2017-02-13 12:38 ` [PATCH v6 6/9] python: Create Python bindings for record history Tim Wiederhake
[not found] ` <1486989450-11313-8-git-send-email-tim.wiederhake@intel.com>
2017-02-13 17:03 ` [PATCH v6 7/9] python: Implement btrace " Doug Evans
2017-02-13 17:12 ` Doug Evans
[not found] ` <1486989450-11313-9-git-send-email-tim.wiederhake@intel.com>
2017-02-13 17:17 ` [PATCH v6 8/9] python: Add tests for record Python bindings Doug Evans
2017-02-13 17:18 ` [PATCH v6 0/9] Python bindings for btrace recordings Doug Evans
2017-02-14 10:20 ` Wiederhake, Tim
2017-02-14 16:22 ` Doug Evans [this message]
2017-02-15 7:35 ` Wiederhake, Tim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP9bCMQbxHFJEggtnzNUZ-_JhUtifMq8s-Fva33heR6=CLZ7cw@mail.gmail.com' \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=palves@redhat.com \
--cc=tim.wiederhake@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).