From: Doug Evans <xdje42@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Gary Benson <gbenson@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3 v2] Implement completion limiting
Date: Sat, 24 Jan 2015 08:50:00 -0000 [thread overview]
Message-ID: <CAP9bCMQn89=-0UrCMMnL5jYCegGbOzTc1syKff_TiVm3QM-iVw@mail.gmail.com> (raw)
In-Reply-To: <83wq4ds0lh.fsf@gnu.org>
On Fri, Jan 23, 2015 at 12:28 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Fri, 23 Jan 2015 08:56:59 -0800
>> From: Doug Evans <xdje42@gmail.com>
>> Cc: Gary Benson <gbenson@redhat.com>,
>> "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
>>
>> How often will there be exactly N?
>
> About the same frequency as there will be exactly N-1, I guess.
My point is, given any particular value I set for
"set max-completions N", what's the probability
that exactly that N completions will be found?
Rather low I expect.
>> And in that particular and massively rare case,
>> once gdb has found N, how much extra work will
>> be performed searching the entire executable
>> and all its shared libraries just to verify there are
>> in fact no more completions?
>> [because that's what has to happen if
>> we're to avoid printing *any* message]
>>
>> The user waits 5 minutes for the entire list and
>> gets her 200 completions, and wonders
>> why it took so long. Then she digs a bit
>> deeper and finds out they were found
>> in the first 5 seconds. Ugh.
>
> 200 is just a random number. It's not magic in any way. So you
> could have 199 completions found in the first 5 sec, followed by 5
> minutes of waiting for the 200th which is never found. Ugh.
>
> There's no way around this issue.
But if I, as a user, do "set max-completions 199"
and then find out gdb is looking for 200 completions
I would be disappointed. I might file a bug report even.
If I do "set max-completions N" I expect gdb to stop looking
when it gets to N.
>> I don't see the benefit of going to the trouble
>> of avoiding printing any message when there are
>> exactly N completions.
>
> That's fine, but then the option's name and its documentation should
> be changed to reflect this. They currently support what I thought
> user will get, not what you describe above.
The option name and documentation is fine.
If I do "set max-completions 42" I expect
gdb to stop looking when it finds 42 completions.
It's a rather straightforward interpretation of the option's
name IMO.
next prev parent reply other threads:[~2015-01-24 0:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 13:16 [PATCH 0/3 v2] Abort completion when list becomes large Gary Benson
2014-11-27 13:16 ` [PATCH 1/3 v2] Add expansion_notify callback to expand_symtabs_matching Gary Benson
2014-12-05 7:56 ` Doug Evans
2014-11-27 13:16 ` [PATCH 2/3 v2] Interleave completion list building with symbol table expansion Gary Benson
2014-12-05 22:58 ` Doug Evans
2017-01-09 21:19 ` Crash regression for <tab>-completion [Re: [PATCH 2/3 v2] Interleave completion list building with symbol table expansion] Jan Kratochvil
2014-11-27 13:16 ` [PATCH 3/3 v2] Implement completion limiting Gary Benson
2014-11-27 16:25 ` Eli Zaretskii
2014-12-05 23:54 ` Doug Evans
2014-12-10 12:22 ` Gary Benson
2014-12-10 16:25 ` Doug Evans
2015-01-03 2:09 ` Doug Evans
2015-01-07 8:44 ` Gary Benson
2015-01-09 1:29 ` Doug Evans
2015-01-10 2:32 ` Doug Evans
2015-01-10 9:23 ` Eli Zaretskii
2015-01-12 18:50 ` Doug Evans
2015-01-15 15:39 ` Gary Benson
2015-01-23 7:32 ` Doug Evans
2015-01-23 10:59 ` Eli Zaretskii
2015-01-23 16:38 ` Doug Evans
2015-01-23 16:49 ` Eli Zaretskii
2015-01-23 20:28 ` Doug Evans
2015-01-24 1:55 ` Eli Zaretskii
2015-01-24 8:50 ` Doug Evans [this message]
2015-01-24 14:12 ` Eli Zaretskii
2015-01-25 15:55 ` Doug Evans
2015-01-25 19:14 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2014-11-06 10:50 [PATCH 0/3 v2] Limit tab-completion result when list is large Gary Benson
2014-11-06 10:51 ` [PATCH 3/3 v2] Implement completion limiting Gary Benson
2014-11-06 16:28 ` Eli Zaretskii
2014-11-21 10:46 ` Gary Benson
2014-11-24 6:09 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP9bCMQn89=-0UrCMMnL5jYCegGbOzTc1syKff_TiVm3QM-iVw@mail.gmail.com' \
--to=xdje42@gmail.com \
--cc=eliz@gnu.org \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).