From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-121558-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 94288 invoked by alias); 6 Apr 2015 15:35:00 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 94190 invoked by uid 89); 6 Apr 2015 15:34:59 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-qc0-f180.google.com
Received: from mail-qc0-f180.google.com (HELO mail-qc0-f180.google.com) (209.85.216.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 06 Apr 2015 15:34:58 +0000
Received: by qcgx3 with SMTP id x3so10787907qcg.3        for <gdb-patches@sourceware.org>; Mon, 06 Apr 2015 08:34:56 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.140.48.37 with SMTP id n34mr10637477qga.8.1428334496436; Mon, 06 Apr 2015 08:34:56 -0700 (PDT)
Received: by 10.229.119.10 with HTTP; Mon, 6 Apr 2015 08:34:56 -0700 (PDT)
In-Reply-To: <m3zj8t3ulo.fsf@seba.sebabeach.org>
References: <m3zj8t3ulo.fsf@seba.sebabeach.org>
Date: Mon, 06 Apr 2015 15:35:00 -0000
Message-ID: <CAP9bCMR4J7GWb8RfJFhiCQg1Ha_91xbeze+pFyZu=oPUkOnh1A@mail.gmail.com>
Subject: Re: [PATCH] symbol cache: hash STRUCT_DOMAIN symbols as VAR_DOMAIN
From: Doug Evans <xdje42@gmail.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-04/txt/msg00146.txt.bz2

On Wed, Feb 4, 2015 at 7:28 PM, Doug Evans <xdje42@gmail.com> wrote:
> Hi.
>
> While looking at the contents of the symbol cache after adding support
> for trying multiple slots I noticed structs occupying more than one slot.
> This is due to symbol_matches_domain support.
> This patch fixes it by treating STRUCT_DOMAIN as VAR_DOMAIN
> when computing the hash.
>
> I also added symbol domain names to debugging output as it was useful.
>
> 2015-02-04  Doug Evans  <xdje42@gmail.com>
>
>         * symtab.c (hash_symbol_entry): Hash STRUCT_DOMAIN symbols as
>         VAR_DOMAIN.
>         (symbol_cache_lookup): Clarify use of bsc_ptr, slot_ptr parameters.
>         Include symbol domain in debugging output.

Committed.