From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53846 invoked by alias); 27 Oct 2015 15:47:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53836 invoked by uid 89); 27 Oct 2015 15:47:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f171.google.com Received: from mail-yk0-f171.google.com (HELO mail-yk0-f171.google.com) (209.85.160.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 27 Oct 2015 15:47:30 +0000 Received: by ykba4 with SMTP id a4so216543807ykb.3 for ; Tue, 27 Oct 2015 08:47:28 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.129.102.9 with SMTP id a9mr6009463ywc.104.1445960848160; Tue, 27 Oct 2015 08:47:28 -0700 (PDT) Received: by 10.13.203.208 with HTTP; Tue, 27 Oct 2015 08:47:28 -0700 (PDT) In-Reply-To: <562F77F6.60503@redhat.com> References: <560AA051.6060803@redhat.com> <562F77F6.60503@redhat.com> Date: Tue, 27 Oct 2015 17:34:00 -0000 Message-ID: Subject: Re: [PATCH] [PR symtab/17911] Recognize bad file types From: Doug Evans To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00629.txt.bz2 On Tue, Oct 27, 2015 at 6:11 AM, Pedro Alves wrote: > On 10/26/2015 11:44 PM, Doug Evans wrote: >> Pedro Alves writes: >>> Seems like there are function calls after these that may >>> clobber errno. I think it'd be safer to do the usual >>> save_errno = errno; / errno = save_errno; dance. >> >> Does what you're saying apply to the current source base? >> [I think so, just checking. >> And if so, then let's fix that first.] >> > > Like so. So you were referring to the existing code. [One can see this bug easily enough, but it wasn't clear whether you were saying my bug was introducing another bug.] gdb is always more broken than one imagines. :-) LGTM.