public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Doug Evans <xdje42@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] TUI: Expand TABs into spaces
Date: Fri, 16 Jan 2015 17:30:00 -0000	[thread overview]
Message-ID: <CAP9bCMRA_tQ6qLzr3VK-tD+yo0s+oop4MPakGdt1S+B4Pk3QWQ@mail.gmail.com> (raw)
In-Reply-To: <83iog61xrl.fsf@gnu.org>

On Fri, Jan 16, 2015 at 8:43 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Fri, 16 Jan 2015 08:32:15 -0800
>> From: Doug Evans <xdje42@gmail.com>
>> Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
>>
>> >> 2015-01-03  Eli Zaretskii  <eliz@gnu.org>
>> >>
>> >>       * tui/tui-regs.c (tui_register_format): Expand TABs into the
>> >>       appropriate number of spaces.
>> >>
>> >>       * tui/tui-io.c (tui_puts, tui_redisplay_readline): Expand TABs
>> >>       into the appropriate number of spaces.
>>
>> I'd have to read the patch more to say it's ok,
>> but one thing that is missing are comments
>> explaining *why* we are expanding tabs into spaces.
>
> You mean, the fact that the Windows port of ncurses doesn't?  Sure,
> can do that.  But note that a similar feature in displaying the source
> doesn't have any such comments.

Is that in relation to the tabset command?
And is that to provide a knob so that source written
with an expectation that \t was different than 8
can be made readable?

Or is there existing code that is coping with these
windows, umm, quirks?

  reply	other threads:[~2015-01-16 17:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-03 11:30 Eli Zaretskii
2015-01-16 11:17 ` Eli Zaretskii
2015-01-16 16:32   ` Doug Evans
2015-01-16 16:43     ` Eli Zaretskii
2015-01-16 17:30       ` Doug Evans [this message]
2015-01-16 17:53         ` Eli Zaretskii
2015-01-16 18:25           ` Doug Evans
2015-01-16 20:11             ` Eli Zaretskii
2015-01-17  1:02               ` Doug Evans
2015-01-17  7:56                 ` Eli Zaretskii
2015-01-24 14:15     ` Eli Zaretskii
2015-01-25 11:31       ` Doug Evans
2015-01-26 11:42         ` Eli Zaretskii
2015-01-27 11:17           ` Doug Evans
2015-01-31 21:08             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP9bCMRA_tQ6qLzr3VK-tD+yo0s+oop4MPakGdt1S+B4Pk3QWQ@mail.gmail.com \
    --to=xdje42@gmail.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).