From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23001 invoked by alias); 5 Jun 2014 16:19:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22988 invoked by uid 89); 5 Jun 2014 16:19:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f171.google.com Received: from mail-yk0-f171.google.com (HELO mail-yk0-f171.google.com) (209.85.160.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 05 Jun 2014 16:19:23 +0000 Received: by mail-yk0-f171.google.com with SMTP id 142so1010745ykq.16 for ; Thu, 05 Jun 2014 09:19:21 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.236.152.2 with SMTP id c2mr82687684yhk.25.1401985161907; Thu, 05 Jun 2014 09:19:21 -0700 (PDT) Received: by 10.170.150.70 with HTTP; Thu, 5 Jun 2014 09:19:21 -0700 (PDT) In-Reply-To: <20140605130140.GA20572@blade.nx> References: <20140605130140.GA20572@blade.nx> Date: Thu, 05 Jun 2014 16:19:00 -0000 Message-ID: Subject: Re: [PATCH 0/3 v4] Demangler crash handler From: Doug Evans To: Gary Benson Cc: "gdb-patches@sourceware.org" , Andrew Burgess , Eli Zaretskii , Florian Weimer , Mark Kettenis , Pedro Alves , Tom Tromey Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00274.txt.bz2 On Thu, Jun 5, 2014 at 6:01 AM, Gary Benson wrote: > Hi all, > > This patch is an updated version of the demangler crash handler I > posted yesterday. The main changes from the previous version are: > > 1) All #ifdef SIGSEGV conditionals have been removed. > > 2) If the user set "ulimit -c 0" then no core file will be > created and a warning will be printed. This mirrors what > internal_error and internal_warning currently do. > > 3) A separate signal stack is created for the SIGSEGV handler > to allow it to function correctly if the normal process > stack overflows. This signal stack is currently only used > by the SIGSEGV handler--all other signal handlers use the > normal process stack as before. > > Doug requested that I change the patch to emit warnings for every > demangler crash, not just the first. Umm, that's not what I said, to be precise, and it was more of a suggestion for discussion than a request. > I've not done this, my reason > being that subsequent failures could have been caused by the first, > by memory corruption or some leftover state: they could be bogus, > and could lead to us chasing bugs that don't exist. I prefer this > way, but I'm not hung up on it and if it's a blocker for Doug or > anyone else I will add the extra warnings. It's not a blocker to me.