From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22018 invoked by alias); 20 Nov 2014 02:38:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21991 invoked by uid 89); 20 Nov 2014 02:38:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yh0-f53.google.com Received: from mail-yh0-f53.google.com (HELO mail-yh0-f53.google.com) (209.85.213.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 20 Nov 2014 02:38:38 +0000 Received: by mail-yh0-f53.google.com with SMTP id i57so923575yha.12 for ; Wed, 19 Nov 2014 18:38:36 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.236.1.70 with SMTP id 46mr19040121yhc.78.1416451116176; Wed, 19 Nov 2014 18:38:36 -0800 (PST) Received: by 10.170.81.68 with HTTP; Wed, 19 Nov 2014 18:38:36 -0800 (PST) In-Reply-To: <8085.1416430826@usendtaylorx2l> References: <31913.1415655693@usendtaylorx2l> <83mw7ymmdw.fsf@gnu.org> <8085.1416430826@usendtaylorx2l> Date: Thu, 20 Nov 2014 02:38:00 -0000 Message-ID: Subject: Re: RFA info macro [-at LOCATION,] (v2) From: Doug Evans To: David Taylor Cc: "gdb-patches@sourceware.org" , Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00449.txt.bz2 On Wed, Nov 19, 2014 at 1:00 PM, David Taylor wrote: > This adds a NEWS entry as requested by Eli and I believe addresses his > concerns with regard to gdb/doc/gdb.texinfo. The other two files > gdb/macrocmd.c and gdb/testsuite/gdb.base/info-macros.exp are unchanged > from the previous submission. I updated the gdb/ChangeLog entry to > include the gdb/NEWS addition.. > > A few releases ago it was possible to set a location that would be used > by 'info location' by typing something like: > > list file.c:42 > > and then do: > > info macro MACRONAME > > . Sometime between release 7.1 and 7.8 that stopped working. > > The following patch adds the option [-at LOCATION,] to 'info macro' to > enable the use of a user selected location as a documented feature. Hi. The "," in "-at LOCATION," seems a bit random, relative to other commands. Maybe it is the best way to go. If so, I'd like to see the reasons why it exists documented in the code. Can we just remove the , and require -- when necessary?