From: Doug Evans <xdje42@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Anthony Green <green@moxielogic.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH, moxie, sim] Add mul.x and umul.x instruction support
Date: Wed, 24 Dec 2014 17:03:00 -0000 [thread overview]
Message-ID: <CAP9bCMSHaGg6bBLA2+WhLZX4W7MCSa8RJ_BO+_JMJJ1OR8G-6w@mail.gmail.com> (raw)
In-Reply-To: <20141224134337.GR12884@adacore.com>
On Wed, Dec 24, 2014 at 5:43 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> 2014-12-24 Anthony Green <green@moxielogic.com>
>> [...]
> Can you add an empty line after the local variable declarations?
> This is part of GDB's Coding Standard...
>
> Also, you appear to have some code in between local variable
> declarations, which is not allowed (non C90, I think). Can you fix?
Maybe as a "baby step" towards a more modern gdb, can we relax these
for the sim tree?
Just a suggestion, I don't have a strong opinion, other than lamenting
the ways in which gdb is held back.
[I can't remember the last time we had this discussion for the sim tree.
If it was in the recent past, apologies. Let me know and I'll add
something to the wiki
to help prevent bringing this up again, at least in the near future.]
next prev parent reply other threads:[~2014-12-24 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-24 13:36 Anthony Green
2014-12-24 13:43 ` Joel Brobecker
2014-12-24 17:03 ` Doug Evans [this message]
2014-12-24 17:12 ` Joel Brobecker
2014-12-25 13:26 ` Anthony Green
2014-12-26 14:17 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP9bCMSHaGg6bBLA2+WhLZX4W7MCSa8RJ_BO+_JMJJ1OR8G-6w@mail.gmail.com \
--to=xdje42@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=green@moxielogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).