From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26475 invoked by alias); 24 Dec 2014 17:03:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26463 invoked by uid 89); 24 Dec 2014 17:03:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f49.google.com Received: from mail-wg0-f49.google.com (HELO mail-wg0-f49.google.com) (74.125.82.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 24 Dec 2014 17:03:57 +0000 Received: by mail-wg0-f49.google.com with SMTP id n12so11605439wgh.8 for ; Wed, 24 Dec 2014 09:03:54 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.180.90.16 with SMTP id bs16mr52276996wib.4.1419440634151; Wed, 24 Dec 2014 09:03:54 -0800 (PST) Received: by 10.27.39.198 with HTTP; Wed, 24 Dec 2014 09:03:54 -0800 (PST) In-Reply-To: <20141224134337.GR12884@adacore.com> References: <87ioh1890s.fsf@moxielogic.com> <20141224134337.GR12884@adacore.com> Date: Wed, 24 Dec 2014 17:03:00 -0000 Message-ID: Subject: Re: [PATCH, moxie, sim] Add mul.x and umul.x instruction support From: Doug Evans To: Joel Brobecker Cc: Anthony Green , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00624.txt.bz2 On Wed, Dec 24, 2014 at 5:43 AM, Joel Brobecker wrote: >> 2014-12-24 Anthony Green >> [...] > Can you add an empty line after the local variable declarations? > This is part of GDB's Coding Standard... > > Also, you appear to have some code in between local variable > declarations, which is not allowed (non C90, I think). Can you fix? Maybe as a "baby step" towards a more modern gdb, can we relax these for the sim tree? Just a suggestion, I don't have a strong opinion, other than lamenting the ways in which gdb is held back. [I can't remember the last time we had this discussion for the sim tree. If it was in the recent past, apologies. Let me know and I'll add something to the wiki to help prevent bringing this up again, at least in the near future.]