From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-117586-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22872 invoked by alias); 16 Nov 2014 18:32:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 22854 invoked by uid 89); 16 Nov 2014 18:32:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-yk0-f180.google.com
Received: from mail-yk0-f180.google.com (HELO mail-yk0-f180.google.com) (209.85.160.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 16 Nov 2014 18:32:23 +0000
Received: by mail-yk0-f180.google.com with SMTP id 9so3450850ykp.39        for <gdb-patches@sourceware.org>; Sun, 16 Nov 2014 10:32:21 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.170.217.9 with SMTP id j9mr3257356ykf.45.1416162741220; Sun, 16 Nov 2014 10:32:21 -0800 (PST)
Received: by 10.170.81.68 with HTTP; Sun, 16 Nov 2014 10:32:21 -0800 (PST)
In-Reply-To: <20141116110934.GH5774@adacore.com>
References: <alpine.DEB.1.10.1204202134510.19835@tp.orcam.me.uk>	<20120611182043.GA7597@adacore.com>	<alpine.DEB.1.10.1409292313170.4971@tp.orcam.me.uk>	<alpine.DEB.1.10.1410060021570.19130@tp.orcam.me.uk>	<20141116110934.GH5774@adacore.com>
Date: Sun, 16 Nov 2014 18:32:00 -0000
Message-ID: <CAP9bCMSKvBGREy_nXKRbA9E=7QsK1o-roENVms4yVWY4jJ4-8A@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] Correct invalid assumptions made by (mostly) DWARF-2 tests
From: Doug Evans <xdje42@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "Maciej W. Rozycki" <macro@codesourcery.com>, 	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, Rich Fuhler <rich@mips.com>, 	Richard Sandiford <rdsandiford@googlemail.com>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-11/txt/msg00378.txt.bz2

On Sun, Nov 16, 2014 at 3:09 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S
>> ===================================================================
>> --- gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S 2014-10-02 07:56:23.000000000 +0100
>> +++ gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S      2014-10-02 07:58:10.978958268 +0100
>> @@ -15,7 +15,8 @@
>>
>>       .text
>>       .globl main
>> -main:        .byte 0
>> +main:
>> +     .dc.l   0
>
> We've never used .dl.l before, and I don't know how widely available
> it is (in fact, I couldn't find it in the GAS manual). How about using
> .word or .4byte? It would also be consistent with what we've usually be
> using. Would that work?

Agreed.