From: Doug Evans <xdje42@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH][PR symtab/17855] Fix.
Date: Thu, 22 Jan 2015 15:37:00 -0000 [thread overview]
Message-ID: <CAP9bCMSN1GWh15G_XVa5Lp+jenc_F3nF5wGO=D=iaX+Jnd=dxQ@mail.gmail.com> (raw)
In-Reply-To: <54C0E1FF.4050201@redhat.com>
On Thu, Jan 22, 2015 at 3:41 AM, Pedro Alves <palves@redhat.com> wrote:
> Looking at the whole function, ISTM that the breakpoint_re_set
> call should move further down. I can imagine that breakpoint_re_set
> could well hit a stale pc function cache, cleared only after by
> clear_pc_function_cache. breakpoint.c:parse_breakpoint_sals also
> references the last displayed sal. One would hope that breakpoint
> re-set is independent of that, though the existing comment about
> breakpoint_re_set accessing the current symtab leaves me
> wondering. WDYT?
Fine by me.
next prev parent reply other threads:[~2015-01-22 15:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 6:27 Doug Evans
2015-01-22 11:42 ` Pedro Alves
2015-01-22 15:37 ` Doug Evans [this message]
2015-01-29 8:00 ` Doug Evans
2015-01-29 8:12 ` Joel Brobecker
2015-01-29 10:01 ` Doug Evans
[not found] ` <m3r3ualkvb.fsf@sspiff.org>
2015-02-03 17:02 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP9bCMSN1GWh15G_XVa5Lp+jenc_F3nF5wGO=D=iaX+Jnd=dxQ@mail.gmail.com' \
--to=xdje42@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).