From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29784 invoked by alias); 12 Dec 2014 17:22:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29768 invoked by uid 89); 12 Dec 2014 17:22:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f177.google.com Received: from mail-wi0-f177.google.com (HELO mail-wi0-f177.google.com) (209.85.212.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 12 Dec 2014 17:21:59 +0000 Received: by mail-wi0-f177.google.com with SMTP id l15so3288798wiw.4 for ; Fri, 12 Dec 2014 09:21:56 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.194.222.98 with SMTP id ql2mr29604802wjc.36.1418404914994; Fri, 12 Dec 2014 09:21:54 -0800 (PST) Received: by 10.27.132.70 with HTTP; Fri, 12 Dec 2014 09:21:54 -0800 (PST) In-Reply-To: References: <20120611182043.GA7597@adacore.com> <20141116103721.GG5774@adacore.com> Date: Fri, 12 Dec 2014 17:22:00 -0000 Message-ID: Subject: Re: [PATCH v2 1/2] ISA bit treatment on the MIPS platform From: Doug Evans To: "Maciej W. Rozycki" Cc: Joel Brobecker , "gdb-patches@sourceware.org" , Rich Fuhler , Richard Sandiford Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00291.txt.bz2 On Fri, Dec 12, 2014 at 6:00 AM, Maciej W. Rozycki wrote: > Joel, Doug -- > > On Thu, 4 Dec 2014, Maciej W. Rozycki wrote: > >> > This is not a requirement for your patch, but if you happen to be able >> > to quickly document elf_make_msymbol_special as well, that would be >> > a very welcome and appreciated change. >> >> I have now added these descriptions, with some bias towards the MIPS >> specifics as they are what I am most familiar with. Please let me know >> if you think they might be further improved. > > I haven't heard back from you, so I have applied the change now. > > While reviewing the final ChangeLog entry I discovered I created an > unneeded shadow local variable definition, so in addition to the changes > already posted in this thread I have included the following cleanup, as > obvious, in the final commit. Hi. Thanks very much for the added comments.