From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22865 invoked by alias); 8 Dec 2013 08:34:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22851 invoked by uid 89); 8 Dec 2013 08:34:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f175.google.com Received: from Unknown (HELO mail-we0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 08 Dec 2013 08:34:26 +0000 Received: by mail-we0-f175.google.com with SMTP id t60so2290777wes.34 for ; Sun, 08 Dec 2013 00:34:17 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.180.39.177 with SMTP id q17mr9443594wik.16.1386491656876; Sun, 08 Dec 2013 00:34:16 -0800 (PST) Received: by 10.194.37.73 with HTTP; Sun, 8 Dec 2013 00:34:16 -0800 (PST) In-Reply-To: <52A40015.207@mentor.com> References: <5265022F.8060203@mentor.com> <52654A2C.9010202@redhat.com> <529707C7.4040504@mentor.com> <5298AE7C.6020607@redhat.com> <529C80D2.2080608@mentor.com> <529C9B42.20600@redhat.com> <529D62F7.80701@mentor.com> <52A22582.8040509@redhat.com> <52A40015.207@mentor.com> Date: Sun, 08 Dec 2013 08:34:00 -0000 Message-ID: Subject: Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet From: Doug Evans To: Hui Zhu Cc: Pedro Alves , gdb-patches ml Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00300.txt.bz2 On Sat, Dec 7, 2013 at 9:13 PM, Hui Zhu wrote: > 2013-12-08 Hui Zhu > > PR gdb/16101 > * breakpoint.c (insert_bp_location): Change hw_bp_err_string to > bp_err_string. > > Output error message of software breakpoints. > Make solib error message output use same code with hardware > breakpoints and software breakpoints. > > * remote.c (remote_insert_breakpoint): If this breakpoint has > target-side commands but this stub doesn't support Z0 packets, > throw error. Nit. This changelog is badly formatted. Please fix. I suspect, though this is only based on perusal of the patch, and not close analysis, that you meant to write: PR gdb/16101 * breakpoint.c (insert_bp_location): Change hw_bp_err_string to bp_err_string. Output error message of software breakpoints. Make solib error message output use same code with hardware breakpoints and software breakpoints. * remote.c (remote_insert_breakpoint): If this breakpoint has target-side commands but this stub doesn't support Z0 packets, throw error. [I may have gotten the indentation wrong, cut-n-paste in gmail, blech. The point is the blank line before "Output error ..." is wrong. ISTM.]