public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Doug Evans <xdje42@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [doc RFA] Misc. fixes to Python docs
Date: Mon, 23 Dec 2013 15:35:00 -0000	[thread overview]
Message-ID: <CAP9bCMT9iN77faiOX7d2GLtfHh3f-F4KQLN-QG4=-HhaUfeE-g@mail.gmail.com> (raw)
In-Reply-To: <83a9fs8brb.fsf@gnu.org>

On Sun, Dec 22, 2013 at 7:52 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Doug Evans <xdje42@gmail.com>
>> Date: Sun, 22 Dec 2013 17:58:10 -0800
>>
>> I found this collection of fixes.
>>
>> The @tindex is for consistency with all other such entries.
>>
>> The @code{"charset"} instead of @samp{charset} is for consistency with
>> earlier use.
>
> I question the second issue.  IMO @samp looks much better in print
> than @code{".."}.

I don't have a strong opinion, other than Consistency Is Good.

>> +@findex gdb.VERSION
>> +@defvar gdb.VERSION
>
> @defvar inserts its argument into the index automatically, so no need
> for @findex (which is wrong anyway, since this is a variable, not a
> function).

Heh, righto.
And in fact I have another patch to remove a lot of dupes for some defuns.

>> @@ -26482,7 +26499,6 @@ this function returns @code{None}.
>>  @findex gdb.objfiles
>>  @defun gdb.objfiles ()
>>  Return a sequence of all the objfiles current known to @value{GDBN}.
>> -@xref{Objfiles In Python}.
>>  @end defun
>
> Why did you remove the cross-reference?

We're in the chapter on "Objfiles In Python" and it's telling the
reader "See the chapter on Objfiles In Python."
[Yes, I know xref doesn't expand to include "the chapter on".  I'm
expanding the wording for illustration's sake.]
Self-xrefs feel really out of place.

      reply	other threads:[~2013-12-23 15:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-23  1:58 Doug Evans
2013-12-23  3:52 ` Eli Zaretskii
2013-12-23 15:35   ` Doug Evans [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP9bCMT9iN77faiOX7d2GLtfHh3f-F4KQLN-QG4=-HhaUfeE-g@mail.gmail.com' \
    --to=xdje42@gmail.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).