From: Doug Evans <xdje42@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pedro Alves <palves@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH][PR symtab/17855] Fix.
Date: Thu, 29 Jan 2015 10:01:00 -0000 [thread overview]
Message-ID: <CAP9bCMTGqCfLQx78wRBhG3JCA10tfZ3d5fpagU-bsCf6f2G5Qg@mail.gmail.com> (raw)
In-Reply-To: <20150129071929.GE5193@adacore.com>
On Wed, Jan 28, 2015 at 11:19 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> Aargh - I was working on it just now because I wasn't sure if anyone
> felt they "had the ball on their court".
>
>> Like so?
>>
>> 2015-01-28 Doug Evans <xdje42@gmail.com>
>>
>> PR symtab/17855
>> * symfile.c (clear_symtab_users): Move call to breakpoint_re_set
>> closer to end.
>
> What I've tested is moving the call last, as shown in the attached
> diff. Not technically necessarily better, but as the comment explains,
> I move it last so that it's after we've purged all relevant caches.
> That way, the function is organized in two rough sections:
> - do purges first;
> - do updates next.
> Your comment is a lot more detailed, I like it.
I think yours is fine too.
I'm ok with using it.
next prev parent reply other threads:[~2015-01-29 7:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 6:27 Doug Evans
2015-01-22 11:42 ` Pedro Alves
2015-01-22 15:37 ` Doug Evans
2015-01-29 8:00 ` Doug Evans
2015-01-29 8:12 ` Joel Brobecker
2015-01-29 10:01 ` Doug Evans [this message]
[not found] ` <m3r3ualkvb.fsf@sspiff.org>
2015-02-03 17:02 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP9bCMTGqCfLQx78wRBhG3JCA10tfZ3d5fpagU-bsCf6f2G5Qg@mail.gmail.com \
--to=xdje42@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).