public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Doug Evans <xdje42@gmail.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Unify CLI/TUI tab-completion match list displayers
Date: Wed, 21 Jan 2015 18:20:00 -0000	[thread overview]
Message-ID: <CAP9bCMTWP24_78kL1gX16Bwq_+0J-ygcEm_DwXda+zN_uQ8s9Q@mail.gmail.com> (raw)
In-Reply-To: <m3zj9c9iln.fsf@sspiff.org>

On Wed, Jan 21, 2015 at 8:57 AM, Doug Evans <xdje42@gmail.com> wrote:
> Hi.
>
> This patch unifies CLI/TUI tab-completion match list displayers.
> In doing so it fixes a few bugs:
>
> - TUI now has pagination of match list output (yay)
> - directories in TUI output get / appended (minor yay)
> - fixes Ctrl-g handling in the CLI version (yay)
>   [There are some other nits which the CLI version has, e.g., if
>   gdb displays output after the first tab (dwarf complaints) then
>   the prompt + text thus far isn't re-printed, presumably because
>   readline isn't aware of the output.  I'm leaving that for another pass,
>   but I like fixing Ctrl-g now.]
>
> ...
>
> +   This function handles the LIST_MAYBE_TRUNCATED marker that we add to the
> +   completion list.
> +
> +   Note: While LIST_MAYBE_TRUNCATED contributes to MAX, it's not long enough
> +   that we worry about it.  */

Bleah.  Ignore this part of the patch.
That's part of a followup patch.
Fixing TUI match list pagination (that heads in a direction of
completely cleaning up TUI match list display) is enough for me to
push this in now.

      reply	other threads:[~2015-01-21 18:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21 16:59 Doug Evans
2015-01-21 18:20 ` Doug Evans [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP9bCMTWP24_78kL1gX16Bwq_+0J-ygcEm_DwXda+zN_uQ8s9Q@mail.gmail.com \
    --to=xdje42@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).