From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10426 invoked by alias); 21 Jan 2015 18:20:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10393 invoked by uid 89); 21 Jan 2015 18:20:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f174.google.com Received: from mail-we0-f174.google.com (HELO mail-we0-f174.google.com) (74.125.82.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 21 Jan 2015 18:20:40 +0000 Received: by mail-we0-f174.google.com with SMTP id x3so11145776wes.5 for ; Wed, 21 Jan 2015 10:20:36 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.180.83.98 with SMTP id p2mr59969939wiy.76.1421864436888; Wed, 21 Jan 2015 10:20:36 -0800 (PST) Received: by 10.27.39.198 with HTTP; Wed, 21 Jan 2015 10:20:36 -0800 (PST) In-Reply-To: References: Date: Wed, 21 Jan 2015 18:20:00 -0000 Message-ID: Subject: Re: [PATCH] Unify CLI/TUI tab-completion match list displayers From: Doug Evans To: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00577.txt.bz2 On Wed, Jan 21, 2015 at 8:57 AM, Doug Evans wrote: > Hi. > > This patch unifies CLI/TUI tab-completion match list displayers. > In doing so it fixes a few bugs: > > - TUI now has pagination of match list output (yay) > - directories in TUI output get / appended (minor yay) > - fixes Ctrl-g handling in the CLI version (yay) > [There are some other nits which the CLI version has, e.g., if > gdb displays output after the first tab (dwarf complaints) then > the prompt + text thus far isn't re-printed, presumably because > readline isn't aware of the output. I'm leaving that for another pass, > but I like fixing Ctrl-g now.] > > ... > > + This function handles the LIST_MAYBE_TRUNCATED marker that we add to the > + completion list. > + > + Note: While LIST_MAYBE_TRUNCATED contributes to MAX, it's not long enough > + that we worry about it. */ Bleah. Ignore this part of the patch. That's part of a followup patch. Fixing TUI match list pagination (that heads in a direction of completely cleaning up TUI match list display) is enough for me to push this in now.