From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6982 invoked by alias); 26 May 2014 03:29:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6965 invoked by uid 89); 26 May 2014 03:29:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f171.google.com Received: from mail-yk0-f171.google.com (HELO mail-yk0-f171.google.com) (209.85.160.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 26 May 2014 03:29:21 +0000 Received: by mail-yk0-f171.google.com with SMTP id 142so5721396ykq.30 for ; Sun, 25 May 2014 20:29:20 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.236.169.105 with SMTP id m69mr32045006yhl.79.1401074959866; Sun, 25 May 2014 20:29:19 -0700 (PDT) Received: by 10.170.150.70 with HTTP; Sun, 25 May 2014 20:29:19 -0700 (PDT) In-Reply-To: <1400885374-18915-5-git-send-email-donb@codesourcery.com> References: <1398885482-8449-1-git-send-email-donb@codesourcery.com> <1400885374-18915-5-git-send-email-donb@codesourcery.com> Date: Mon, 26 May 2014 03:29:00 -0000 Message-ID: Subject: Re: [PATCH 4/4] Non-stop exec tests From: Doug Evans To: Don Breazeal Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00624.txt.bz2 On Fri, May 23, 2014 at 3:49 PM, Don Breazeal wrote: > This patch extends the non-ldr-exc-*.exp tests so that they run all their= cases in non-stop mode as well as all-stop mode. These tests cover handli= ng of exec events when non-leader threads call exec. > > The tests now report 'untested when 'runto_main' fails. In non-stop mode= with 'target extended-remote', runto_main always fails with something like: > > (gdb) run > Starting program: /home/me/gdb/testsuite/gdb.threads/non-ldr-exc-4 > Unexpected vCont reply in non-stop mode: T0506:10e0ffffff7f0000;07:c8deff= ffff7f0000;10:c1a6abaaaa2a0000;thread:p5ee.5ee;core:0; Did you try --target_board=3Dnative-extended-gdbserver ? > This happens in other tests as well (e.g. gdb.threads/thread_events.exp),= so I copied the error handling from that test so that the non-stop tests r= eport 'untested' for target extended-remote. I couldn't find anything rela= ted to this in the gdb bug database, but I assume it is a known problem sin= ce the other tests handle it. > > Regards, > --Don > > testsuite/ > 2014-05-22 Don Breazeal > > * gdb.threads/non-ldr-exc-1.exp: Add non-stop cases > * gdb.threads/non-ldr-exc-2.exp: Ditto. > * gdb.threads/non-ldr-exc-3.exp: Ditto. > * gdb.threads/non-ldr-exc-4.exp: Ditto. Hi. Still going through the patch series, but have an initial comment. The following test at the top of each .exp file could be changed to something like !linux && is_remote, right? # No exec event support in the remote protocol. if { [is_remote target] } then { continue } These tests now pass with native-gdbserver (and native-extended-gdbserver) so we'll want to at least run these tests with those, I presume.