From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29852 invoked by alias); 20 Dec 2014 19:14:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29841 invoked by uid 89); 20 Dec 2014 19:14:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f49.google.com Received: from mail-wg0-f49.google.com (HELO mail-wg0-f49.google.com) (74.125.82.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 20 Dec 2014 19:14:43 +0000 Received: by mail-wg0-f49.google.com with SMTP id n12so3831199wgh.36 for ; Sat, 20 Dec 2014 11:14:40 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.181.28.165 with SMTP id jp5mr16951241wid.76.1419102880009; Sat, 20 Dec 2014 11:14:40 -0800 (PST) Received: by 10.27.132.70 with HTTP; Sat, 20 Dec 2014 11:14:39 -0800 (PST) In-Reply-To: <83d27esisa.fsf@gnu.org> References: <83d27esisa.fsf@gnu.org> Date: Sat, 20 Dec 2014 19:14:00 -0000 Message-ID: Subject: Re: [PATCH] symbol lookup cache From: Doug Evans To: Eli Zaretskii Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00593.txt.bz2 On Sat, Dec 20, 2014 at 2:43 AM, Eli Zaretskii wrote: >> From: Doug Evans >> Date: Fri, 19 Dec 2014 23:56:23 -0800 >> >> Here is an updated patch for the symbol cache, >> with docs and ChangeLog entry. > > Btw, I wonder if this should be a user option, not a "maint" option. > The heuristics used to determine the cache size tend to be wrong in > some rare corner cases, so letting the user override this should be a > good thing, I think. The thought is the fewer knobs the user needs the better, and that's where potentially dynamically adjusting the size comes in. It's easier to remove/change maint options, so for now I put the size there until there's data to guide a better choice. But, ultimately, making it a user-settable option is definitely a possibility.