From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 1C7D93858433 for ; Wed, 10 Apr 2024 10:02:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C7D93858433 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1C7D93858433 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712743363; cv=none; b=Hz592zMBqnvcV37B7okSPn4XNGjWiciGZQbeNlVN223b0RrXn0DykwfqmM+kevSGd773dhXxQRf0/8q3Kc22jAScvgd6l29c2BMUYJCG2ZcksOxSpWzcQjdAWZPKhKUSrv1VCNuQ1gGrKkLEmfxatnmcjSKc/wfiony5D9dIUHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712743363; c=relaxed/simple; bh=9B1Vn8eSiE+8OVVqmfdFpO08lD+T2epGIRQ1Nqk5zfg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=JOrkl8TFKU9ZJsThndQZN8FU/BWGnANY4dirX31U79IFNtd8gdNgAwvm0GScOjlExbTgD8ooYTmN3xsAdS9HkodqF9Tcum0VwqdOrwqjYxNWtFV+R0E24fUde1amkhLM8jWQ3hQ5eihOjOyhRBikpZUyjbxkZIH22GcRhMMIaNM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a51c6e91793so587591766b.0 for ; Wed, 10 Apr 2024 03:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712743360; x=1713348160; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Rji7m4tWfuei8nvpJt7uFXvmKMTw+wbhvZQbsAFZvsw=; b=rGFqW5bkxhYKA3349qPidVvqGgAGFcfFZCuTLIK5bDfhqkg4LOGG5O4sw7Xe/BxQTI cijYTbEOitQjdVtefHyL/IKyucz9dUjXFcyYhCYuFNQxhbHZuyO5YIXjGSthLek/VzWL IhU1Za5y7/pvCUbu8M4uc2Br2gG2qekGlipi+rHChwXpd0ZG3xDxVQFwVqjzQkeq9tug dh6MHt7hRMEU0sh/tsphzfGG1k7qmdd5HsoaPL4MOpFfkv/iTtV0DIyu27uGuIQkF7wD OLWe1AoDa9vKZ7BBTYzDrs0ZpLNOL2nwKTZtIs81z2szp+9bJuntOPmJnUShKwubbKci mZmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712743360; x=1713348160; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rji7m4tWfuei8nvpJt7uFXvmKMTw+wbhvZQbsAFZvsw=; b=ib8XFLXpJcun26Sksri9J4uxGALAsQQkMBKC6E5derUPEbOjUGBUMYQgYckyMH+pYp H94QvNTGNaA0LnsW8r3221L/zXnh2b1dT4EdGLhHXhrUgqkoNT+CwlEwlsfJXSJRfXe4 tx3WKFxt/uJk1imPsmDvTsyeYAb7uCNcmp671Q9ka7XQTDRrZ4vRCwpPeK1AaEkjfCB+ 2Cs6PV90ejnKqNi8HIg/HTtbp1GqgG9mVsENuud3sTAkPgCkQLBTRQnvGn7P2w8ybOGc U08Tq05b2I0srjiSFd8WuO/I3HxFD1ZfpwQCglYca8QgOxry+Tz8yaGhSM8sDZWpJbVp H+mA== X-Gm-Message-State: AOJu0Yx7vzx/sNhHJ/Egc4aUzIiSHbn5xiMgESJrksl8ktT3K6NWSWUN LP4BQBDe/V1YtqENUtG94gHXa2W3ibhLe5GPqxW41yCmXo0+tEV7E11iL7Z2tfawCYRcyVb+QBz LECA2l5w1oK6teXhWesGzj9kKq9iYDvskD+S5dg== X-Google-Smtp-Source: AGHT+IFIsyqfe+BDz3ovYG6/hWCqxbHwjZr42OhP6qVT6Ygec00fElgfIuHCsMktDSYeCLzwAsBL+mrbMjAzEmV/ihs= X-Received: by 2002:a17:906:2844:b0:a52:a25:2077 with SMTP id s4-20020a170906284400b00a520a252077mr1259721ejc.14.1712743359654; Wed, 10 Apr 2024 03:02:39 -0700 (PDT) MIME-Version: 1.0 References: <20240407191027.118770-1-christophe.lyon@linaro.org> <50664a13-d38a-42f8-9fa7-19824afb64a4@arm.com> In-Reply-To: From: Christophe Lyon Date: Wed, 10 Apr 2024 12:02:32 +0200 Message-ID: Subject: Re: [PATCH v2] gdb, gdbserver: Add missing install-dvi Makefile target To: Luis Machado Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 10 Apr 2024 at 10:10, Christophe Lyon wrote: > > On Wed, 10 Apr 2024 at 01:00, Luis Machado wrote: > > > > On 4/7/24 20:10, Christophe Lyon wrote: > > > For some reason install-dvi is missing although other targets of the > > > same family are present. This looks like an oversight. > > > > > > This enables calling 'make install-dvi' from the top-level build > > > directory. > > > > > > Fix what looks like another oversight: include 'pdf' in 'all-doc' in > > > gdb/doc/Makefile.in. > > > --- > > > gdb/Makefile.in | 2 +- > > > gdb/data-directory/Makefile.in | 2 +- > > > gdb/doc/Makefile.in | 19 +++++++++++++++++-- > > > gdb/testsuite/Makefile.in | 1 + > > > gdbserver/Makefile.in | 1 + > > > 5 files changed, 21 insertions(+), 4 deletions(-) > > > > > > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > > > index 40732cb2227..d001359539a 100644 > > > --- a/gdb/Makefile.in > > > +++ b/gdb/Makefile.in > > > @@ -2035,7 +2035,7 @@ check-headers: > > > done > > > .PHONY: check-headers > > > > > > -info install-info clean-info dvi pdf install-pdf html install-html: force > > > +info install-info clean-info dvi install-dvi pdf install-pdf html install-html: force > > > @$(MAKE) $(FLAGS_TO_PASS) DO=$@ "DODIRS=$(SUBDIRS)" subdir_do > > > > > > # Traditionally "install" depends on "all". But it may be useful > > > diff --git a/gdb/data-directory/Makefile.in b/gdb/data-directory/Makefile.in > > > index 2a40be4ade0..2db8706eba6 100644 > > > --- a/gdb/data-directory/Makefile.in > > > +++ b/gdb/data-directory/Makefile.in > > > @@ -422,7 +422,7 @@ maintainer-clean realclean distclean: clean > > > .PHONY: install-info install-pdf install-html clean-info > > > check installcheck: > > > info dvi pdf html: > > > -install-info install-pdf install-html: > > > +install-info install-dvi install-pdf install-html: > > > clean-info: > > > > > > # GNU Make has an annoying habit of putting *all* the Makefile variables > > > diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in > > > index 04f9dbd27f0..8007f6373d4 100644 > > > --- a/gdb/doc/Makefile.in > > > +++ b/gdb/doc/Makefile.in > > > @@ -24,6 +24,7 @@ prefix = @prefix@ > > > infodir = @infodir@ > > > datarootdir = @datarootdir@ > > > docdir = @docdir@ > > > +dvidir = @dvidir@ > > > pdfdir = @pdfdir@ > > > htmldir = @htmldir@ > > > mandir = @mandir@ > > > @@ -87,6 +88,8 @@ SET_TEXINPUTS = \ > > > # Files which should be generated via 'info' and installed by 'install-info' > > > INFO_DEPS = gdb.info stabs.info annotate.info > > > > > > +# Files which should be generated via 'dvi' and installed by 'install-dvi' > > > +DVIFILES = gdb.dvi stabs.dvi refcard.dvi annotate.dvi > > > # Files which should be generated via 'pdf' and installed by 'install-pdf' > > > PDFFILES = gdb.pdf stabs.pdf refcard.pdf annotate.pdf > > > # Files which should be generated via 'html' and installed by 'install-html' > > > @@ -191,7 +194,7 @@ HAVE_NATIVE_GCORE_HOST = @HAVE_NATIVE_GCORE_HOST@ > > > all: info > > > > > > info: $(INFO_DEPS) > > > -dvi: gdb.dvi stabs.dvi refcard.dvi annotate.dvi > > > +dvi: $(DVIFILES) > > > ps: gdb.ps stabs.ps refcard.ps annotate.ps > > > html: $(HTMLFILES) > > > pdf: $(PDFFILES) > > > @@ -233,7 +236,7 @@ Doxyfile-gdb-xref: $(srcdir)/Doxyfile-gdb-xref.in > > > Doxyfile-gdbserver: $(srcdir)/Doxyfile-gdbserver.in > > > $(doxyedit) $(srcdir)/Doxyfile-gdbserver.in >Doxyfile-gdbserver > > > > > > -all-doc: info dvi ps # pdf > > > +all-doc: info dvi ps pdf > > > diststuff: info man > > > rm -f gdb-cfg.texi > > > > > > @@ -293,6 +296,18 @@ install-html: $(HTMLFILES) > > > fi; \ > > > done > > > > > > +dvi__strip_dir = `echo $$p | sed -e 's|^.*/||'`; > > > + > > > +install-dvi: $(DVIFILES) > > > + @$(NORMAL_INSTALL) > > > + test -z "$(dvidir)" || $(mkinstalldirs) "$(DESTDIR)$(dvidir)" > > > + @list='$(DVIFILES)'; for p in $$list; do \ > > > + if test -f "$$p"; then d=; else d="$(srcdir)/"; fi; \ > > > + f=$(dvi__strip_dir) \ > > > + echo " $(INSTALL_DATA) '$$d$$p' '$(DESTDIR)$(dvidir)/$$f'"; \ > > > + $(INSTALL_DATA) "$$d$$p" "$(DESTDIR)$(dvidir)/$$f"; \ > > > + done > > > + > > > pdf__strip_dir = `echo $$p | sed -e 's|^.*/||'`; > > > > > > install-pdf: $(PDFFILES) > > > diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in > > > index f6603daf7fd..f799f16c2bb 100644 > > > --- a/gdb/testsuite/Makefile.in > > > +++ b/gdb/testsuite/Makefile.in > > > @@ -105,6 +105,7 @@ INFODIRS=doc > > > info: > > > install-info: > > > dvi: > > > +install-dvi: > > > pdf: > > > install-pdf: > > > html: > > > diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in > > > index d12f8746611..4eed8926f48 100644 > > > --- a/gdbserver/Makefile.in > > > +++ b/gdbserver/Makefile.in > > > @@ -342,6 +342,7 @@ installcheck: > > > check: > > > info dvi pdf: > > > install-info: > > > +install-dvi: > > > install-pdf: > > > html: > > > install-html: > > > > I gave this a try and install-dvi almost fully works from the top level, though it still fails for gprofng. > > > > Maybe something for the binutils folks? Otherwise this part looks OK to me. > > Thanks for checking. Yes IIUC gprofng is part of binutils, and I > didn't notice because we don't build it ;-) > This patch should fix it: https://sourceware.org/pipermail/binutils/2024-April/133528.html Thanks, Christophe > Thanks, > > Christophe