From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 32A823858415 for ; Thu, 29 Feb 2024 17:40:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 32A823858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 32A823858415 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709228402; cv=none; b=B5ts91/V/xAEEFRDNTjot0KFhio7pm7+StKCewS+oPABXNlH7CZUhRyW+oVrY3gC/wqne6OcjZi5GsBTI0E3HjkncAVat00LTflQbWuqKaV6II0Ha3b+t2PhHmYvnYsweb6Jc60DLouvivyBmIDsEBD54Gjrg2pQMzYQdXJLdK4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709228402; c=relaxed/simple; bh=eir2AEzfQncMrXp0ASilc1NMGa/5gMfbMPA+UJSGHpg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=iMgKVNsHUy6j3IkV1qoOQakYZ8DtzFcJJAXZbMrrje49ylhBeOeqG0xL8bbnONxLrz59uZUQJuDXDMwbCixtdHvj1F6/lvsUhwrVYlWTxE+O8kbS/IM4FLw5Ef8PGaXTutJBJGxzUgZ0qtqm8EJWe3Dxy3vbUx65KqaLWQf7He0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a446478b04bso71592566b.3 for ; Thu, 29 Feb 2024 09:40:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709228399; x=1709833199; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eir2AEzfQncMrXp0ASilc1NMGa/5gMfbMPA+UJSGHpg=; b=j5Rjry1yuQgupm4YfnmHbbI96XcwVgQH8vfJY+xDmBbb3gFek3I5D4q3w0cQnudJMQ lWcYZrlyJWkVDmyN5vJb8C55jmSr+ObhVaHeFciUiSXSzzQorVhOJJ1IwVP67S73FYJK 1DTxeDgLaMIeUyX26+cqHdt8SOHdCnHxRdFr/LrFvomRz/9EcUY3e8ya71VB8REft0kQ om77h7WnAIZC3YmCoE6uIoq10PTdgVbZsJhzJUUtz5h+ka5/SL/dOgN6YC8DnO0IwPG9 SzzsUd7aE72OaxkBB9vDn9icZIyfHyOIu2RX1QLITa+rQ/U9uMcx5UGT/MOd0lw4q4QU XmqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709228399; x=1709833199; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eir2AEzfQncMrXp0ASilc1NMGa/5gMfbMPA+UJSGHpg=; b=caqaEA975BRW7tOhIYScG1T5NAu1UauA0wjACrxnhNK0Aim3T+p6h1PR1Pv1XPeZSR gb48U16MsA1A4gqQYJJjGVn+LTesJT7J19c27Lpld3e5MPBSJEgmUzigDQibE8fHDypL qreCZVFacek7jOIDmOCnn70H4WGEfu/EOF96f9iKIFDdJYKywHI96SwR0fIU6IHnigtC c7HJCmsVaCMbSqbnZlcIhppbX6WYo30ErDN14K65Lqer3rK9DtqoWdfcFuc0N08yYhvZ uFaJYCD7KDt4WQZlhqBFN1pWMZSmiyHc5uxbB5Lqji1m9cOKGdkNDZOXjxJOpy8u8/fy L8OQ== X-Forwarded-Encrypted: i=1; AJvYcCU5q9xLvxyNAkI93EEQe6KyTIorubSfdS8+ttcK7E0120R0lmy8nIFj9YXxHAqIW46GUL8zbczZWSjfOvW/BpozFAmMP01RJa0WkA== X-Gm-Message-State: AOJu0YwR94HLVGn2hIYmoBzBNhMabI5srpr0a7w1b+zpuis0AOx1wNVd 1chy3oQMn7Zog4fkhVl5+4Bua/CLAH5J4HBU+2dAg6GzNgKZKIDVvU9NUbIMXSKMYSy4EneTqOK OCIgFNOqXXkrAT5UUDNoF1EkXDpp3QWN5FkjFPQ== X-Google-Smtp-Source: AGHT+IEkgAv75qQeqV/8seWNQYGRpHPl+TLdH3V1+AOFVAZ2xJ7m5slF4PBFlsK6i4zGnkOoVKnsqWP7MyP16nAJAdE= X-Received: by 2002:a17:906:507:b0:a44:6b6b:bae3 with SMTP id j7-20020a170906050700b00a446b6bbae3mr493263eja.59.1709228398797; Thu, 29 Feb 2024 09:39:58 -0800 (PST) MIME-Version: 1.0 References: <20240229110039.GB18580@gnu.wildebeest.org> In-Reply-To: <20240229110039.GB18580@gnu.wildebeest.org> From: Christophe Lyon Date: Thu, 29 Feb 2024 18:39:54 +0100 Message-ID: Subject: Re: Help needed with maintainer-mode To: Mark Wielaard Cc: binutils@sourceware.org, GCC Mailing List , gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 29 Feb 2024 at 12:00, Mark Wielaard wrote: > > Hi Christophe, > > On Thu, Feb 29, 2024 at 11:22:33AM +0100, Christophe Lyon via Gcc wrote: > > I've noticed that sourceware's buildbot has a small script > > "autoregen.py" which does not use the project's build system, but > > rather calls aclocal/autoheader/automake/autoconf in an ad-hoc way. > > Should we replicate that? > > That python script works across gcc/binutils/gdb: > https://sourceware.org/cgit/builder/tree/builder/containers/autoregen.py > > It is installed into a container file that has the exact autoconf and > automake version needed to regenerate the autotool files: > https://sourceware.org/cgit/builder/tree/builder/containers/Containerfile-autotools > > And it was indeed done this way because that way the files are > regenerated in a reproducible way. Which wasn't the case when using --enable-maintainer-mode (and autoreconfig also doesn't work). I see. So it is possibly incomplete, in the sense that it may lack some of the steps that maintainer-mode would perform? For instance, gas for aarch64 has some *opcodes*.c files that need regenerating before committing. The regeneration step is enabled in maintainer-mode, so I guess the autoregen bots on Sourceware would miss a problem with these files? Thanks, Christophe > > It is run on all commits and warns if it detects a change in the > (checked in) generated files. > https://builder.sourceware.org/buildbot/#/builders/gcc-autoregen > https://builder.sourceware.org/buildbot/#/builders/binutils-gdb-autoregen > > Cheers, > > Mark