From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 3483C3858D29 for ; Mon, 17 Jun 2024 08:16:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3483C3858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3483C3858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718612222; cv=none; b=RYG5GSbd/oPqCRPykUnvfXmNJOjztDhwlQh+dQqkv270rZ4mGJSPOasjXeAg60bUDNM+0iuDjfG/WwNMEdSVzu5s3B8HexDYb+L16AaoualqiAXDLaaW7PR2wyvsRRcsC3Y2tfCZr6JK0JmkpEVbfH3O9zO5DuP77R31f6zVM78= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718612222; c=relaxed/simple; bh=sMStyuat4w+nPP0NjIc7yOjWYTb6abEzNKmOz3AUINg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=tsSLT+ORGldiLzkR51YOhvRkXa0oDWo/DNSCJF9sduv4CX6cD1qwGLKaxgAVJ7LJ+O3j2awt1MvvJzr2eTWwtDL1QWHnG6VSlPdraGSv6KmK2H29RElnTiscjGctB6xP9dHN97Ly2NcY0xZyJF6vFrUFiNAvl3sR7NNX6IWfdKg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-57cad4475e0so7075050a12.1 for ; Mon, 17 Jun 2024 01:16:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718612218; x=1719217018; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Dtgc2Oss/YloinUxUXJwYzFpAdJLrolBZDDQZ4gE1yk=; b=sQzw31Iv1/Ys6TFrendz1Izv56weu14Zi5QE2Hiz06SI8o0CY3DULS7TnHyc88qbsf 1da/lg4IRO9AGdcS5KCEGFWrorH0P4rYxvy7XQ4zyHqPr80gtu+S1n4fJHUgWe2CwNrD 1J1fubcwPbUpSNfoAsGHf08QESNFHCvD2hDKLrFXWW9sY5JcQlKDZAxh+GkvLqM57K8i HFNNpdKhjL+3OebaZBsHmpyLdVrPXlCDDSQv7VIzzoJ5KRnkyzeWMxdKLJTA126/LhaG 2bjRRYNlZgMLXZ7iO3UygFKIWuwWB9pLyMklgqRbQqz8Z/2kGReRWa5y13OUziQYFKDX y+Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718612218; x=1719217018; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Dtgc2Oss/YloinUxUXJwYzFpAdJLrolBZDDQZ4gE1yk=; b=J95jLqTMZjHQ6IsqS4+g1hYUrNRvpw0u+1YIBwYPF8V8Pff626kmMg/Sg22J7ZTpQj 6K6qBSuqgJzJX3SLrMxveUGzvJariUL/Iy0LzA/LF5pQyIK4Xov5nLUg6SS01G+bsuR0 G+vFTDtvonKQJf3lARCgSaV1MdqGfrl4tcsRqBLzKZcXpl8ARj+xL/IsFzRCj3H0Nybk kpkGdXovk4pg1jOuBKTp/zkRgFcWZJFIfbUZOtfFrFucFFJGyt+VfT3+1+w502hnRF5N Ksp2LEO+8Y2hprc6BaZSML6GV9kMDwV/zLmaRz7m8jW4wk0tv0ewjbW8ltGQjBW7YwCf dVFw== X-Gm-Message-State: AOJu0Yx8c2z/S71Csqtvpi7cAVZFZKT/KQ0jzzAyAole3tVWzrB0bFkK Y9k3zb8zyu388ZAb3dUCcxI5avoIxjde/XuWe7uHyVurI61IxJVUVvX/hB2HP48q99lggzc2Pfs sZiy4IjbEXGZegnOci/968RxzIM5M/+5loURedikhAUZYLzls/Wq17g== X-Google-Smtp-Source: AGHT+IHVAV3V7ZtMo5ycI3YddkOkYrO89/nkSEIKXkL0+w8za8+nru2Zo6I6ZlUQgTQpLsXbL/zRI6S2PFQHx9ATCl8= X-Received: by 2002:a17:907:6d15:b0:a6f:5609:954f with SMTP id a640c23a62f3a-a6f6082cefcmr757380566b.12.1718612217607; Mon, 17 Jun 2024 01:16:57 -0700 (PDT) MIME-Version: 1.0 References: <20240521154415.9543-1-tdevries@suse.de> <44fac677-58a3-4bd6-956f-a20615652cdf@suse.de> In-Reply-To: <44fac677-58a3-4bd6-956f-a20615652cdf@suse.de> From: Christophe Lyon Date: Mon, 17 Jun 2024 10:16:46 +0200 Message-ID: Subject: Re: [PATCH 01/11] [gdb/testsuite] Add gdb.base/fission-macro.exp To: Tom de Vries Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom, On Thu, 13 Jun 2024 at 17:40, Tom de Vries wrote: > > On 5/21/24 17:44, Tom de Vries wrote: > > Starting with gcc commit 80048aa13a6 ("debug/111409 - don't generate COMDAT > > macro sections for split DWARF"), available from release gcc 14.1 onwards, gcc > > produces a usable dwarf-5 32-bit .debug_macro.dwo section. > > > > Add a test-case excercising this. > > > > I went ahead and pushed this patch, since it only adds a test-case. > As you may have noticed, this patch was flagged by our CI on arm: FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32: strict_dwarf=0: info macro FIRST FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32: strict_dwarf=0: info macro FOURTH FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32: strict_dwarf=0: info macro SECOND FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32: strict_dwarf=0: info macro THIRD FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32: strict_dwarf=1: info macro FIRST FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32: strict_dwarf=1: info macro FOURTH FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32: strict_dwarf=1: info macro SECOND FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32: strict_dwarf=1: info macro THIRD >From gdb.log I can see: info macro FIRST Defined at /home/tcwg-buildslave/workspace/tcwg_gnu_2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.base/fission-macro.c:0 -DFIRST=1 (gdb) FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32: strict_dwarf=0: info macro FIRST info macro SECOND Defined at /home/tcwg-buildslave/workspace/tcwg_gnu_2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.base/fission-macro.c:0 -DSECOND=2 (gdb) FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32: strict_dwarf=0: info macro SECOND info macro THIRD Defined at /home/tcwg-buildslave/workspace/tcwg_gnu_2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.base/fission-macro-2.c:0 -DTHIRD=3 (gdb) FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32: strict_dwarf=0: info macro THIRD info macro FOURTH Defined at /home/tcwg-buildslave/workspace/tcwg_gnu_2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.base/fission-macro-2.c:0 -DFOURTH=4 (gdb) FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32: strict_dwarf=0: info macro FOURTH I've also noticed: get_compiler_info: gcc-15-0-0 (which is expected, this CI loop is using trunk GCC) Does this help? Thanks, Christophe > Thanks, > - Tom > > > Tested on x86_64-linux. > > > > Tested test-case using a current gcc trunk build, and gcc 14. > > --- > > gdb/testsuite/gdb.base/fission-macro-2.c | 27 +++++++++ > > gdb/testsuite/gdb.base/fission-macro.c | 27 +++++++++ > > gdb/testsuite/gdb.base/fission-macro.exp | 75 ++++++++++++++++++++++++ > > 3 files changed, 129 insertions(+) > > create mode 100644 gdb/testsuite/gdb.base/fission-macro-2.c > > create mode 100644 gdb/testsuite/gdb.base/fission-macro.c > > create mode 100644 gdb/testsuite/gdb.base/fission-macro.exp > > > > diff --git a/gdb/testsuite/gdb.base/fission-macro-2.c b/gdb/testsuite/gdb.base/fission-macro-2.c > > new file mode 100644 > > index 00000000000..fb088c8bfaf > > --- /dev/null > > +++ b/gdb/testsuite/gdb.base/fission-macro-2.c > > @@ -0,0 +1,27 @@ > > +/* This testcase is part of GDB, the GNU debugger. > > + > > + Copyright 2024 Free Software Foundation, Inc. > > + > > + This program is free software; you can redistribute it and/or modify > > + it under the terms of the GNU General Public License as published by > > + the Free Software Foundation; either version 3 of the License, or > > + (at your option) any later version. > > + > > + This program is distributed in the hope that it will be useful, > > + but WITHOUT ANY WARRANTY; without even the implied warranty of > > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + GNU General Public License for more details. > > + > > + You should have received a copy of the GNU General Public License > > + along with this program. If not, see . */ > > + > > +#define THIRD 3 > > +#define FOURTH 4 > > + > > +extern int foo (void); > > + > > +int > > +foo (void) > > +{ > > + return 0; > > +} > > diff --git a/gdb/testsuite/gdb.base/fission-macro.c b/gdb/testsuite/gdb.base/fission-macro.c > > new file mode 100644 > > index 00000000000..9c8cbece5c5 > > --- /dev/null > > +++ b/gdb/testsuite/gdb.base/fission-macro.c > > @@ -0,0 +1,27 @@ > > +/* This testcase is part of GDB, the GNU debugger. > > + > > + Copyright 2024 Free Software Foundation, Inc. > > + > > + This program is free software; you can redistribute it and/or modify > > + it under the terms of the GNU General Public License as published by > > + the Free Software Foundation; either version 3 of the License, or > > + (at your option) any later version. > > + > > + This program is distributed in the hope that it will be useful, > > + but WITHOUT ANY WARRANTY; without even the implied warranty of > > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + GNU General Public License for more details. > > + > > + You should have received a copy of the GNU General Public License > > + along with this program. If not, see . */ > > + > > +#define FIRST 1 > > +#define SECOND 2 > > + > > +extern int foo (void); > > + > > +int > > +main (void) > > +{ > > + return foo (); > > +} > > diff --git a/gdb/testsuite/gdb.base/fission-macro.exp b/gdb/testsuite/gdb.base/fission-macro.exp > > new file mode 100644 > > index 00000000000..705e3dd0c4b > > --- /dev/null > > +++ b/gdb/testsuite/gdb.base/fission-macro.exp > > @@ -0,0 +1,75 @@ > > +# Copyright 2024 Free Software Foundation, Inc. > > + > > +# This program is free software; you can redistribute it and/or modify > > +# it under the terms of the GNU General Public License as published by > > +# the Free Software Foundation; either version 3 of the License, or > > +# (at your option) any later version. > > +# > > +# This program is distributed in the hope that it will be useful, > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > +# GNU General Public License for more details. > > +# > > +# You should have received a copy of the GNU General Public License > > +# along with this program. If not, see . */ > > + > > +# Gcc 14 is the first release containing the fix for PR debug/111409. > > +require {expr [gcc_major_version] >= 14} > > + > > +standard_testfile .c -2.c > > + > > +proc do_tests { dwarf_version dwarf_bits strict_dwarf } { > > + set opts {} > > + lappend opts debug > > + lappend opts quiet > > + lappend opts additional_flags=-gsplit-dwarf > > + lappend opts macros > > + > > + if { $dwarf_bits == 64 } { > > + lappend opts additional_flags=-gdwarf64 > > + } > > + > > + if { $strict_dwarf } { > > + lappend opts additional_flags=-gstrict-dwarf > > + } > > + > > + lappend opts additional_flags=-gdwarf-$dwarf_version > > + > > + set id v$dwarf_version-b$dwarf_bits-s$strict_dwarf > > + > > + set srcfiles [list $::srcfile $::srcfile2] > > + if { [build_executable "failed to prepare" $::testfile-$id $srcfiles $opts] } { > > + return -1 > > + } > > + > > + clean_restart > > + > > + gdb_load_no_complaints $::binfile-$id > > + > > + if {![runto_main]} { > > + return 0 > > + } > > + > > + gdb_test "p FIRST" " = 1" > > + gdb_test "p SECOND" " = 2" > > + > > + gdb_test "info macro FIRST" "#define FIRST 1" > > + gdb_test "info macro SECOND" "#define SECOND 2" > > + > > + gdb_breakpoint foo > > + gdb_continue_to_breakpoint "foo" > > + > > + gdb_test "p THIRD" " = 3" > > + gdb_test "p FOURTH" " = 4" > > + > > + gdb_test "info macro THIRD" "#define THIRD 3" > > + gdb_test "info macro FOURTH" "#define FOURTH 4" > > +} > > + > > +foreach_with_prefix dwarf_version {5} { > > + foreach_with_prefix dwarf_bits {32} { > > + foreach_with_prefix strict_dwarf {0 1} { > > + do_tests $dwarf_version $dwarf_bits $strict_dwarf > > + } > > + } > > +} > > > > base-commit: 05887e360ad3db3265e3dc2f7a845660d1d3c02f >