public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Christophe Lyon <christophe.lyon@linaro.org>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 01/11] [gdb/testsuite] Add gdb.base/fission-macro.exp
Date: Mon, 17 Jun 2024 10:43:22 +0200	[thread overview]
Message-ID: <CAPS5kha2NZ=ReebwQQjEyi062PyEo5CipFgO8PhpsuOHJhCEHQ@mail.gmail.com> (raw)
In-Reply-To: <957e19ba-e05c-40eb-928b-6b12e342ff84@suse.de>

On Mon, 17 Jun 2024 at 10:22, Tom de Vries <tdevries@suse.de> wrote:
>
> On 6/17/24 10:16, Christophe Lyon wrote:
> > Hi Tom,
> >
> > On Thu, 13 Jun 2024 at 17:40, Tom de Vries <tdevries@suse.de> wrote:
> >>
> >> On 5/21/24 17:44, Tom de Vries wrote:
> >>> Starting with gcc commit 80048aa13a6 ("debug/111409 - don't generate COMDAT
> >>> macro sections for split DWARF"), available from release gcc 14.1 onwards, gcc
> >>> produces a usable dwarf-5 32-bit .debug_macro.dwo section.
> >>>
> >>> Add a test-case excercising this.
> >>>
> >>
> >> I went ahead and pushed this patch, since it only adds a test-case.
> >>
> >
> > As you may have noticed, this patch was flagged by our CI on arm:
> > FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32:
> > strict_dwarf=0: info macro FIRST
> > FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32:
> > strict_dwarf=0: info macro FOURTH
> > FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32:
> > strict_dwarf=0: info macro SECOND
> > FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32:
> > strict_dwarf=0: info macro THIRD
> > FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32:
> > strict_dwarf=1: info macro FIRST
> > FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32:
> > strict_dwarf=1: info macro FOURTH
> > FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32:
> > strict_dwarf=1: info macro SECOND
> > FAIL: gdb.base/fission-macro.exp: dwarf_version=5: dwarf_bits=32:
> > strict_dwarf=1: info macro THIRD
> >
> >
> >  From gdb.log I can see:
> > info macro FIRST
> > Defined at /home/tcwg-buildslave/workspace/tcwg_gnu_2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.base/fission-macro.c:0
> > -DFIRST=1
> > (gdb) FAIL: gdb.base/fission-macro.exp: dwarf_version=5:
> > dwarf_bits=32: strict_dwarf=0: info macro FIRST
> > info macro SECOND
> > Defined at /home/tcwg-buildslave/workspace/tcwg_gnu_2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.base/fission-macro.c:0
> > -DSECOND=2
> > (gdb) FAIL: gdb.base/fission-macro.exp: dwarf_version=5:
> > dwarf_bits=32: strict_dwarf=0: info macro SECOND
> >
> > info macro THIRD
> > Defined at /home/tcwg-buildslave/workspace/tcwg_gnu_2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.base/fission-macro-2.c:0
> > -DTHIRD=3
> > (gdb) FAIL: gdb.base/fission-macro.exp: dwarf_version=5:
> > dwarf_bits=32: strict_dwarf=0: info macro THIRD
> > info macro FOURTH
> > Defined at /home/tcwg-buildslave/workspace/tcwg_gnu_2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.base/fission-macro-2.c:0
> > -DFOURTH=4
> > (gdb) FAIL: gdb.base/fission-macro.exp: dwarf_version=5:
> > dwarf_bits=32: strict_dwarf=0: info macro FOURTH
> >
> >
> > I've also noticed:
> > get_compiler_info: gcc-15-0-0
> >
> > (which is expected, this CI loop is using trunk GCC)
> >
> > Does this help?
>
> Hi Christophe,
>
> Thanks for the info.
>
> Indeed I already noticed it, and filed this PR (
> https://sourceware.org/bugzilla/show_bug.cgi?id=31897 ) to track it.
>
> I managed to reproduce it, and AFAICT it's fixed by the following patch
> in the patch series (something I didn't realize when committing, because
> this FAIL occurs only on 32-bit targets).
>
> Sorry for the noise.
>

Thanks for the pointer, I had missed it.

Christophe

> Thanks,
> - Tom

      reply	other threads:[~2024-06-17  8:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21 15:44 Tom de Vries
2024-05-21 15:44 ` [PATCH 02/11] [gdb/macros] Handle 64-bit dwarf in gdb.base/fission-macro.exp Tom de Vries
2024-05-21 15:44 ` [PATCH 03/11] [gdb/testsuite] Add test-case gdb.base/fission-macro-i.exp Tom de Vries
2024-06-13 16:27   ` Tom de Vries
2024-05-21 15:44 ` [PATCH 04/11] [gdb/macros] Work around gcc PR debug/99319 Tom de Vries
2024-05-21 15:44 ` [PATCH 05/11] [gdb/macros] Work around a gcc PR fixed in gcc 9 Tom de Vries
2024-05-21 15:44 ` [PATCH 06/11] [gdb/macros] Handle v4 dwarf in gdb.base/fission-macro.exp Tom de Vries
2024-05-21 15:44 ` [PATCH 07/11] [gdb/macros] Workaround gcc PR debug/115066 Tom de Vries
2024-05-21 15:44 ` [PATCH 08/11] [gdb/testsuite] Extend gdb.base/fission-macro.exp Tom de Vries
2024-05-21 15:44 ` [PATCH 09/11] [gdb/macros] Fix gdb.base/fission-macro.exp with clang Tom de Vries
2024-05-21 15:44 ` [PATCH 10/11] [gdb/testsuite] Use -g3 in gdb.base/lineinc.exp Tom de Vries
2024-05-21 15:44 ` [PATCH 11/11] [gdb/testsuite] Don't use readelf in gdb/contrib/cc-with-tweaks.sh Tom de Vries
2024-06-13 15:40 ` [PATCH 01/11] [gdb/testsuite] Add gdb.base/fission-macro.exp Tom de Vries
2024-06-17  8:16   ` Christophe Lyon
2024-06-17  8:23     ` Tom de Vries
2024-06-17  8:43       ` Christophe Lyon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPS5kha2NZ=ReebwQQjEyi062PyEo5CipFgO8PhpsuOHJhCEHQ@mail.gmail.com' \
    --to=christophe.lyon@linaro.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).