From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id CAAF93858D20 for ; Sun, 7 Apr 2024 19:08:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CAAF93858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CAAF93858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::532 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712516906; cv=none; b=qCWoldhgZJPExEVa/7OKP4Kx7zKgXzn3NEdZXmKX/KSpTzwzTqcocxTT0QDWPAviFWLG21DZemDJ/JlnJJiIcNQjopKYGI+ZWDJPB77tCkTbM6u1LrBFDwiO8BmLkfQ4Tc/TDgvQ0uYk2F42WQgiE1Rxv8DLHu501+5tTkefMMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712516906; c=relaxed/simple; bh=Fqd+Nr5MrwLNW4PwOIHOiPBrFrQqE1WIOr2v3XqHW90=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=IL0mFyxAHTmFHGnJL4PTRxFDG6ZrFv72Fe90CR/1E9KcvbOsp4MjOKoQE6TZUG3j7/s+71SslaSa8f5DaMcZRjkU0e7+333V4XYjj5LHvWoAh6ruTW4VY2pLzWvPe7gmekZTOpXS+9AJSP9z5DSbW07IKFJuNMDp3SSRRTdLblA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-56e4a148aecso847447a12.1 for ; Sun, 07 Apr 2024 12:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712516903; x=1713121703; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=u3Gtp032iUu6YvF8o5tsBc7RX0FhiS4dPxu3YQhohz8=; b=Obd39rhnN2v3twdoPckj4YZdZkxUN/2GgUo1kERZMgo1FE5N2THG+e1mFX5qNgoVly 3T5pc3K7xgdDR9jwo6lW9ZPxyUdMRZ33KehrAGcTkbbq7Lce2B6T47LPd/W7RjubaGPH 23iXpUG2SCuZYeOS/JsXXFnug0SqH2WwDLWCgAKMU9vCXEdlN+BYqz4x28MxorXAPo6h R1ENl9G2APDHVf5n9BSPDdUBPodErFqhskfjB7J6Fvj/gLQK0GRVVYS8VMmxSaWUDqWo 9kDCDGGiDspTjFG2RwGNTrqFCFVzZgykJSVvghhWie3gLW/qq8np80PHa2t3OlvKOp8k 0wOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712516903; x=1713121703; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u3Gtp032iUu6YvF8o5tsBc7RX0FhiS4dPxu3YQhohz8=; b=NLoQCIizCi3fm/XcHf+Nh9Icv82SRM+XYMtnfOEkDNjrMiU1Wjfr3AXcxprYomIHrp oogApEQ+9MzjPoTGmZB0w7TL4DshYFVxv7mUKnRzf1FOvCEavIS6iaaajz7Pdd8tCtbu hdmmgkdNKqgM62+pDT87WlcsxsikJHw/isztze5ZCkeauw+yJHCZS8SPBv44d9TrodFn SgPwbH6KjjXaeg5969bXkekV2YquyVZi9TiX4DV7yIFAszTRzZ3NPo+ieqfXOzf44L0q xf3qLIqjAF6F8FmkNu2IETeBLTwxr3x5fg18f0II/XR6XMFxhPnYpyaJZYVr0cT7Mx9l cKQw== X-Gm-Message-State: AOJu0Ywb2TeJgnbkUwTqIvT/+6sz6O4WDIp1y1L5WsPKzMmP2wTQC//c UUSadHebqvouYeeTCDzRSAzAB16DumgakCstBb8q3d0qwhQpK4T0aiNPj+brt2T4FNkvaRpPxtk 1ci9ENOS2eNNyTZpa4iTPe31YgwvKD31X2LUISbJSPKj+baXI X-Google-Smtp-Source: AGHT+IHS8gzZEv92WH3yWsGde26l7Oyt2Os20Gn39hB15cw3iikeu1PCCHvm6MA2jtHfx+CpupCuSGYP0blvEmsNmd4= X-Received: by 2002:a50:aa91:0:b0:56e:34db:f5ef with SMTP id q17-20020a50aa91000000b0056e34dbf5efmr4333840edc.28.1712516903237; Sun, 07 Apr 2024 12:08:23 -0700 (PDT) MIME-Version: 1.0 References: <20240404215910.57477-1-christophe.lyon@linaro.org> <87jzlb9li9.fsf@linaro.org> In-Reply-To: <87jzlb9li9.fsf@linaro.org> From: Christophe Lyon Date: Sun, 7 Apr 2024 21:08:12 +0200 Message-ID: Subject: Re: [PATCH] gdb: Add missing install-dvi Makefile target To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 6 Apr 2024 at 06:13, Thiago Jung Bauermann wrote: > > > Hello Christophe, > > Thank you for the patch! Just a couple of minor comments: > > Christophe Lyon writes: > > > For some reason install-dvi is missing although other targets of the > > same family are present. This looks like an oversight. > > > > This enables calling 'make install-dvi' from the top-level build > > directory. > > I can confirm that 'make install-dvi' works from inside $BUILD/gdb, but > from $BUILD I get this error: > > Doing install-dvi in libdecnumber > make[2]: Entering directory '/home/thiago.bauermann/.cache/builds/gdb-native/libdecnumber' > make[2]: *** No rule to make target 'install-dvi'. Stop. > make[2]: Leaving directory '/home/thiago.bauermann/.cache/builds/gdb-native/libdecnumber' > make[1]: *** [Makefile:7855: install-dvi-libdecnumber] Error 1 > make[1]: Leaving directory '/home/thiago.bauermann/.cache/builds/gdb-native' > make: *** [Makefile:1669: do-install-dvi] Error 2 > Hmmm so the master copy of libdecnumber is in GCC IIUC, which does contain the install-dvi target. Looks like gdb needs to sync with gcc's current version of libdecnumber? (which should be a different patch, of course) > With 'make -k' I see that gdbserver also lacks an install-dvi target. Ack, sorry for missing this (our build script does not try to build any doc from gdbserver. In fact, the man page for gdbserver is part of gdb/doc, but there's no other doc for gdbserver there (no info/dvi/pdf/texinfo). Is that expected? IIUC gdbserver.1 is extracted from the main gdb.texinfo, but there's no such rule to generate gdbserver.{info/dvi/pdf/html}, an oversight? > > > @@ -233,7 +236,7 @@ Doxyfile-gdb-xref: $(srcdir)/Doxyfile-gdb-xref.in > > Doxyfile-gdbserver: $(srcdir)/Doxyfile-gdbserver.in > > $(doxyedit) $(srcdir)/Doxyfile-gdbserver.in >Doxyfile-gdbserver > > > > -all-doc: info dvi ps # pdf > > +all-doc: info dvi ps pdf > > diststuff: info man > > rm -f gdb-cfg.texi > > This seems unrelated. > Indeed, that doesn't match the subject/commit message I proposed, I can put this into a separate patch if you want, or document this change in the commit message: it looks like an other oversight? Thanks, Christophe > -- > Thiago