From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by server2.sourceware.org (Postfix) with ESMTPS id 2963E381DCF7 for ; Sat, 7 Mar 2020 20:02:04 +0000 (GMT) Received: by mail-oi1-x243.google.com with SMTP id v19so6160809oic.12 for ; Sat, 07 Mar 2020 12:02:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y3RBUCmrVPqrndZEgbAf77DSzK93Zol85uxATjkvRlY=; b=Q7dQH7HACa248GyS9XcRHPH9Wb425peMjZrXbrIk8UzGTSShW3pqDlwy+9FUQcuP11 Q+wsrC9aIdLSbCFe9zzJf7hiHaM4uYJvv4IyKTEpI5x2K1UA3Wuqplab2GIPKUQqrrvH cg7HN0FwtF7q45lM+Esm+LPCNwyTo5C/3Xo+7QNDo3CmNY8iunq5dIvcMWZJDQb6HmFd OCph4A2jEaF7qUmQ8vOgtT6fe6Hoi6nTtOpciBPnAWlDBmhglp2Y4KriqrhtTHfFdYPa Q3KghPdEJe4eA7QioCjc7ugp7sMUX2KTU0RqVZ+JhsxmF5D85avkxpDnbVobuqrZttdM GK9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y3RBUCmrVPqrndZEgbAf77DSzK93Zol85uxATjkvRlY=; b=DBi9JC+bCN7WPgDkoJI+WDn0jAEJLYdmZVhOaIygkWTYZrfz1ayi1S47dSSYCMr3HV tJihrged2SGCqnIqLH/Z+ji9Yn/dB9ftQpisAsI6dvJ5WzIibc02sZw3908JGJrBhsMB sfik6reRJtXkmbe7P2tN/YINHiaEq1dB+Hl0LXmG9VOs0VdFi0rbBzt4MydBohbw7/9a mxDnBtQSV61brUd6tnKuHyLm/LtY8OLDUeAFX3P8Qha9IL9uz4Xvk4g76WsLx0a1r3oQ KZ67pf2zKo282SUM1sUb7tV+rLOJzx/aSvLYRT9MjhC0UhlI5n4s2+jF7HVNIARWcpJN WDHg== X-Gm-Message-State: ANhLgQ03SifFwt6r6ryEfEAyaGahVKYpT4d23DvSCj8IGyxC13MO5ORY 8vDOWiqJ+GeJV81VAx+Pfd5cwM5RpDervwPO25NSANiy X-Google-Smtp-Source: ADFU+vvLV4N//fmClFiOiokszIncl0i9AkosdkAPN81dpzJyC8eyBkG3rnjEjK+PQHxgY6spzhHJV/IXhYDVATpIQHo= X-Received: by 2002:aca:c70f:: with SMTP id x15mr6591090oif.80.1583611323162; Sat, 07 Mar 2020 12:02:03 -0800 (PST) MIME-Version: 1.0 References: <20200215165444.32653-1-tom@tromey.com> <20200215165444.32653-2-tom@tromey.com> <01167589-fae4-39a0-1ebe-0c7d4cbf52b5@simark.ca> <87o8tu3c1g.fsf@tromey.com> <87o8tu86ci.fsf@tromey.com> <3a3f1f39-c715-58ba-06a8-2980afb82c53@simark.ca> <87d0a9nqyy.fsf@tromey.com> In-Reply-To: <87d0a9nqyy.fsf@tromey.com> From: Christian Biesinger Date: Sat, 7 Mar 2020 13:12:56 -0600 Message-ID: Subject: Re: [PATCH 01/14] Fix latent bug in dwarf2_find_containing_comp_unit To: Tom Tromey Cc: Simon Marchi , gdb-patches X-Spam-Status: No, score=-15.7 required=5.0 tests=BAYES_40, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Mar 2020 20:02:04 -0000 Re std::binary_search, we do have GDB::binary_search which is more useful/easier to use. On Thu, Feb 20, 2020, 10:50 Tom Tromey wrote: > >>>>> "Simon" == Simon Marchi writes: > > Simon> Thanks, that LGTM. If you want to use std::binary_search, that > would be fine > Simon> as well. > > I tried this but it wasn't notably simpler and it meant changes to the > error handling, so I dropped it. > > Tom >