From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by sourceware.org (Postfix) with ESMTPS id E29BB3858403 for ; Mon, 1 Nov 2021 18:29:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E29BB3858403 Received: by mail-qv1-xf2b.google.com with SMTP id u25so11821333qve.2 for ; Mon, 01 Nov 2021 11:29:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=W+1dKZr9edADlxG52fQJ3Fy1hQN7isHCsIFUSnNarDY=; b=Q1IUBvpbWCpnGRi15VvfyxZRde9Ib23yK8zCX4Q0jvT6OPa7z+5Zn5jMIvuyLMTvzs cBoDZSz6i8TbK/mwJjjQgtgGcE1bdSO1tc4w+FdUjPQnkQDOfi4LYbR4ujPO5f9s0Fhz LBF2tx0PUKw3+hNQErg4/VhvODdBV2TpkcKGPbXd2+GujquAdstm09n+ZzHeBaxwWXFF qbHoacC3AmT1fxyg6LBE468mMPDLrSfesuhYohuU82YwGmlpcoPi0r6Xw9KLfUY7woOK 1xYFQmPpem6XXgZXyMHHWeAajoxP25ldyqCn8X0jvCa39Qp44e02wUJPPbSi5NPgw7Cg VTBw== X-Gm-Message-State: AOAM5323iCtkYTP83j9nx4wOkibZpfj622Nf6L9YbwfUCXoSezfyPz3G XGWpwr3ZzzL9QJNjXBcaj9cdkESEQuTZkaG3U43rpLcDUVA= X-Google-Smtp-Source: ABdhPJz/vfhaMMBPN34dLI8cDpGxCg9UEQS0mVpFh6sl6y7a8YwqSBHuAQ1KVPkdZMMOtK38RgRNfh7HzN5W4DpWIF4= X-Received: by 2002:a05:6214:224d:: with SMTP id c13mr30412899qvc.37.1635791366233; Mon, 01 Nov 2021 11:29:26 -0700 (PDT) MIME-Version: 1.0 References: <20211101034519.29154-1-vapier@gentoo.org> In-Reply-To: From: Christian Biesinger Date: Mon, 1 Nov 2021 14:28:48 -0400 Message-ID: Subject: Re: [PATCH] sim: mn10300: clean up pointer casts To: Christian Biesinger , gdb-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.3 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2021 18:29:28 -0000 On Mon, Nov 1, 2021 at 12:22 PM Mike Frysinger wrote: > > On 01 Nov 2021 12:07, Christian Biesinger wrote: > > On Sun, Oct 31, 2021 at 11:45 PM Mike Frysinger via Gdb-patches > > wrote: > > > --- a/sim/mn10300/dv-mn103ser.c > > > +++ b/sim/mn10300/dv-mn103ser.c > > > @@ -238,7 +238,7 @@ do_polling_event (struct hw *me, > > > { > > > SIM_DESC sd = hw_system (me); > > > struct mn103ser *serial = hw_data(me); > > > - long serial_reg = (long) data; > > > + long serial_reg = (uintptr_t) data; > > > > Shouldn't you change the variable type too? > > the types are already confused, but long here is fine as any other. uintptr_t > is not really any more correct. serial_reg comes in as an unsigned_word via > the memory read/write callbacks, (encoded) cast to void*, and (decoded) cast > to long. the memory read/write callbacks verify the values are always within > the serial_register_types enum range which looks like [0,16] range, so any of > these types work. > > > Otherwise this patch seems to be somewhat pointless? > > if ( nr_bytes == 1 ) > > i don't know which one you mean, or why you think any of them are pointless. > the nr_bytes checks are in the read/write code paths of the memory mapped > register callbacks. so nr_bytes is needed & correct there. I forgot to delete that nr_bytes line; the pointless comment was about casting to uintprtr_t but still storing the result in a long. Why not keep it as a cast to long then? Christian