From: Christian Biesinger <cbiesinger@google.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/8] Remove target_has_stack macro
Date: Tue, 21 Jul 2020 12:12:09 -0500 [thread overview]
Message-ID: <CAPTJ0XE4LRkN3UK=omAsGZARc-gy-4qB8rgcpM0Du82VOQnsfw@mail.gmail.com> (raw)
In-Reply-To: <20200721014914.29937-4-tom@tromey.com>
On Mon, Jul 20, 2020 at 8:49 PM Tom Tromey <tom@tromey.com> wrote:
> --- a/gdb/ada-tasks.c
> +++ b/gdb/ada-tasks.c
> @@ -999,7 +999,7 @@ ada_build_task_list ()
> {
> struct ada_tasks_inferior_data *data;
>
> - if (!target_has_stack)
> + if (!target_has_stack ())
> error (_("Cannot inspect Ada tasks when program is not running"));
A bit of a tangent, but either the check or the error message seems
wrong. Does this work when looking at a coredump? If yes, the error is
wrong; if not, the check is wrong.
Christian
next prev parent reply other threads:[~2020-07-21 17:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 1:49 [PATCH 0/8] Remove object-like target macros Tom Tromey
2020-07-21 1:49 ` [PATCH 1/8] Remove target_has_all_memory Tom Tromey
2020-07-21 1:49 ` [PATCH 2/8] Remove target_has_memory macro Tom Tromey
2020-07-21 1:49 ` [PATCH 3/8] Remove target_has_stack macro Tom Tromey
2020-07-21 17:12 ` Christian Biesinger [this message]
2020-09-29 1:36 ` Tom Tromey
2020-07-21 1:49 ` [PATCH 4/8] Remove target_has_registers macro Tom Tromey
2020-07-21 1:49 ` [PATCH 5/8] Turn target_can_execute_reverse into function-like macro Tom Tromey
2020-07-21 2:30 ` Simon Marchi
2020-07-21 17:07 ` Christian Biesinger
2020-09-29 1:36 ` Tom Tromey
2020-07-21 1:49 ` [PATCH 6/8] Remove target_has_execution macro Tom Tromey
2020-07-21 1:49 ` [PATCH 7/8] Turn target_can_lock_scheduler into a function-like macro Tom Tromey
2020-07-21 2:32 ` Simon Marchi
2020-07-21 11:28 ` Tom Tromey
2020-09-29 1:37 ` Tom Tromey
2020-07-21 1:49 ` [PATCH 8/8] Turn target_have_steppable_watchpoint into " Tom Tromey
2020-09-29 1:38 ` [PATCH 0/8] Remove object-like target macros Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XE4LRkN3UK=omAsGZARc-gy-4qB8rgcpM0Du82VOQnsfw@mail.gmail.com' \
--to=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).