From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by sourceware.org (Postfix) with ESMTPS id 3C7A33857C63 for ; Tue, 5 Jan 2021 11:57:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3C7A33857C63 Received: by mail-qk1-x72c.google.com with SMTP id f26so26216244qka.0 for ; Tue, 05 Jan 2021 03:57:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jwh1XBbnhOzI5KTFpUE3ZRTYbRyGi6HPNn5ZMmysJJc=; b=KIZTsPPpBNTEsuKLYKbeVDqKcSGYZuZO9XyiPBm1bPNENPgdA3B28nFNxxpqls9rTc 6SfqbWkKUTcGX8HdAFObwzDjk2aX2qyFL8Fz0PVcx1MiaNHeMOvxLK3iUblbY8WFGzBZ FoQbPurt8BxGiNIkgxA0NNfShPxkL7QXtMrvFIx/gLiwScE45PzwkG6qFkE1gsXpE1wv 7sgBWPRwym5y1fxltG2AwDqUWk7kb+Wz19ZdaJVZ0xY79gelRcZCKkDohignEQpnawQB Y6TxgNGS8BPr3HKHA+h6/9DGhPel3aS08WYpo9w8RFGD6Ila3t0VuDhTWYKMnNWXJC0h wg0w== X-Gm-Message-State: AOAM531TCD0KyEeQ99OTekCOCyyS+XgqaPt+dtq9mqqluBtEpuRrjC7h aGjtTt50XvfueAdVqvhpaUY9q47+ZlWQ3Wlk2TGVQQ== X-Google-Smtp-Source: ABdhPJyswLeb2jeZ62ImxAeGPTXbCA8SaAK7pn09oPNQVXLcf5zRnq3XOrEQn5xl9EBMYXaC6xi6QQhm6XPtKVkjvNc= X-Received: by 2002:a05:620a:12f8:: with SMTP id f24mr75327957qkl.132.1609847866672; Tue, 05 Jan 2021 03:57:46 -0800 (PST) MIME-Version: 1.0 References: <20201221142343.4810-1-ssbssa@yahoo.de> <20201221142343.4810-4-ssbssa@yahoo.de> In-Reply-To: <20201221142343.4810-4-ssbssa@yahoo.de> From: Christian Biesinger Date: Tue, 5 Jan 2021 12:57:09 +0100 Message-ID: Subject: Re: [PATCH 4/4] Prevent flickering when redrawing the TUI source window To: Hannes Domani Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.4 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2021 11:57:48 -0000 On Mon, Dec 21, 2020 at 3:24 PM Hannes Domani via Gdb-patches wrote: > tui_source_window_base::refresh_window () > { > - tui_win_info::refresh_window (); > + wnoutrefresh (handle.get ()); Maybe it would be good to add a comment saying why you're calling wnoutrefresh instead of the superclass? Or is this obvious anyway to someone knowing ncurses? Christian