From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Kamil Rytarowski <n54@gmx.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/3 v2] Define _KMEMUSER in arm-nbsd-nat.c
Date: Fri, 24 Jan 2020 14:34:00 -0000 [thread overview]
Message-ID: <CAPTJ0XENLFx5ZiSSNNk+48DtmpKXB7T3Xn7BGXxKZOXH6D9g9A@mail.gmail.com> (raw)
In-Reply-To: <2afe5687-5be2-7650-d4e3-3aceed3f68f2@gmx.com>
On Fri, Jan 24, 2020 at 3:29 PM Kamil Rytarowski <n54@gmx.com> wrote:
>
> On 24.01.2020 15:18, cbiesinger@chromium.org wrote:
> > From: Christian Biesinger <cbiesinger@google.com>
> >
> > Fixes the below compile error on ARM NetBSD 9.0_RC1 (the only version I
> > tested). types.h does not define register_t by default.
> >
> > We already use this define elsewhere, notably in bsd-kvm.c.
> >
> > In file included from ../../gdb/arm-nbsd-nat.c:28:
> > /usr/include/machine/frame.h:54:2: error: unknown type name 'register_t'; did you mean '__register_t'?
> > register_t tf_spsr;
> > ^
> > /usr/include/machine/types.h:77:14: note: '__register_t' declared here
> > typedef int __register_t;
> > ^
> >
> > There are other compile errors that this does not fix.
> >
> > gdb/ChangeLog:
> >
> > 2020-01-24 Christian Biesinger <cbiesinger@google.com>
> >
> > * arm-nbsd-nat.c: Define _KMEMUSER to get the declaration of
> > register_t.
> >
> > Change-Id: I82c21d38189ee59ea0af2538ba84b771d268722e
> > ---
> > gdb/arm-nbsd-nat.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/gdb/arm-nbsd-nat.c b/gdb/arm-nbsd-nat.c
> > index 00f919194b..4844b51a3c 100644
> > --- a/gdb/arm-nbsd-nat.c
> > +++ b/gdb/arm-nbsd-nat.c
> > @@ -17,6 +17,8 @@
> > You should have received a copy of the GNU General Public License
> > along with this program. If not, see <http://www.gnu.org/licenses/>. */
> >
> > +/* We define this to get types like register_t. */
> > +#define _KMEMUSER
> > #include "defs.h"
> > #include "gdbcore.h"
> > #include "inferior.h"
> >
>
> While gdb is the right user for _KMEMUSER, here we should probably go
> for -D_KERNTYPES as it is the canonical symbol for register_t.
Ah thank you! I was hoping someone who knows this stuff would respond.
I will send a new patch shortly.
Christian
next prev parent reply other threads:[~2020-01-24 14:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 14:15 [PATCH 0/3] Fix some ARM NetBSD compile errors cbiesinger
2020-01-24 14:15 ` [PATCH 1/3] Support the NetBSD version of pthread_setname_np cbiesinger
2020-01-24 14:59 ` Kamil Rytarowski
2020-01-24 15:04 ` Tom Tromey
2020-01-24 14:15 ` [PATCH 3/3] Make the class name in the definition match the declaration cbiesinger
2020-01-24 14:54 ` Kamil Rytarowski
2020-01-24 15:06 ` Tom Tromey
2020-01-24 15:49 ` Christian Biesinger via gdb-patches
2020-01-24 14:18 ` [PATCH 2/3] Define _KMEMUSER in arm-nbsd-nat.c cbiesinger
2020-01-24 14:22 ` [PATCH 2/3 v2] " cbiesinger
2020-01-24 14:32 ` Kamil Rytarowski
2020-01-24 14:34 ` Christian Biesinger via gdb-patches [this message]
2020-01-24 14:36 ` [PATCH v3 2/3] Define _KERNTYPES " cbiesinger
2020-01-24 15:04 ` Tom Tromey
2020-01-24 14:58 ` [PATCH 2/3 v2] Define _KMEMUSER " Christian Biesinger via gdb-patches
2020-01-24 15:36 ` Kamil Rytarowski
2020-01-24 15:37 ` Christian Biesinger via gdb-patches
2020-01-24 15:49 ` Kamil Rytarowski
2020-01-24 16:25 ` Christian Biesinger via gdb-patches
2020-01-24 16:45 ` Kamil Rytarowski
2020-01-27 21:28 ` Christian Biesinger via gdb-patches
2020-02-05 18:02 ` Christian Biesinger via gdb-patches
2020-02-06 13:25 ` Kamil Rytarowski
2020-02-06 13:19 ` Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTJ0XENLFx5ZiSSNNk+48DtmpKXB7T3Xn7BGXxKZOXH6D9g9A@mail.gmail.com \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=n54@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).