From: Christian Biesinger <cbiesinger@google.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Document resolve_dynamic_type oddity
Date: Tue, 19 Oct 2021 17:11:54 -0400 [thread overview]
Message-ID: <CAPTJ0XEybL+F66DoTVE7D15oxN0D2Rc2rab4McNEkNmGDL5dBA@mail.gmail.com> (raw)
In-Reply-To: <20211019204653.3888644-1-tromey@adacore.com>
On Tue, Oct 19, 2021 at 4:47 PM Tom Tromey via Gdb-patches
<gdb-patches@sourceware.org> wrote:
> --- a/gdb/gdbtypes.h
> +++ b/gdb/gdbtypes.h
> @@ -2666,12 +2666,21 @@ extern CORE_ADDR get_pointer_type_max (struct type *);
> /* * Resolve all dynamic values of a type e.g. array bounds to static values.
> ADDR specifies the location of the variable the type is bound to.
> If TYPE has no dynamic properties return TYPE; otherwise a new type with
> - static properties is returned. */
> + static properties is returned.
> +
> + For an array type, if the element type is dynamic, then that will
> + not be resolved. This is done because each individual element may
> + have a different type when resolved (depending on the contents of
> + memory). In this situation, 'is_dynamic_type' will still return
> + type for the return value of this function. */
type -> true?
next prev parent reply other threads:[~2021-10-19 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 20:46 Tom Tromey
2021-10-19 21:11 ` Christian Biesinger [this message]
2021-10-20 17:59 ` Tom Tromey
2021-10-29 13:33 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTJ0XEybL+F66DoTVE7D15oxN0D2Rc2rab4McNEkNmGDL5dBA@mail.gmail.com \
--to=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).