* [PATCH] Remote unnecessary declaration of trace_regblock_size
@ 2019-10-12 5:06 cbiesinger
2019-10-12 23:31 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: cbiesinger @ 2019-10-12 5:06 UTC (permalink / raw)
To: gdb-patches; +Cc: Christian Biesinger
From: Christian Biesinger <cbiesinger@google.com>
This variable is declared in tracepoint.h, which is already included
by remote.c.
gdb/ChangeLog:
2019-10-10 Christian Biesinger <cbiesinger@google.com>
* remote.c (remote_target::get_trace_status): Remove declaration of
trace_regblock_size.
---
gdb/remote.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gdb/remote.c b/gdb/remote.c
index 21160e13acc..73b510dd395 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -13102,14 +13102,13 @@ remote_target::get_trace_status (struct trace_status *ts)
{
/* Initialize it just to avoid a GCC false warning. */
char *p = NULL;
- /* FIXME we need to get register block size some other way. */
- extern int trace_regblock_size;
enum packet_result result;
struct remote_state *rs = get_remote_state ();
if (packet_support (PACKET_qTStatus) == PACKET_DISABLE)
return -1;
+ /* FIXME we need to get register block size some other way. */
trace_regblock_size
= rs->get_remote_arch_state (target_gdbarch ())->sizeof_g_packet;
--
2.23.0.700.g56cf767bdb-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remote unnecessary declaration of trace_regblock_size
2019-10-12 5:06 [PATCH] Remote unnecessary declaration of trace_regblock_size cbiesinger
@ 2019-10-12 23:31 ` Simon Marchi
2019-10-12 23:37 ` Christian Biesinger via gdb-patches
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2019-10-12 23:31 UTC (permalink / raw)
To: cbiesinger; +Cc: gdb-patches, Christian Biesinger
On 2019-10-12 01:05, cbiesinger@chromium.org wrote:
> From: Christian Biesinger <cbiesinger@google.com>
>
> This variable is declared in tracepoint.h, which is already included
> by remote.c.
Remote -> Remove in the title.
Otherwise, that LGTM.
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remote unnecessary declaration of trace_regblock_size
2019-10-12 23:31 ` Simon Marchi
@ 2019-10-12 23:37 ` Christian Biesinger via gdb-patches
0 siblings, 0 replies; 3+ messages in thread
From: Christian Biesinger via gdb-patches @ 2019-10-12 23:37 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
On Sat, Oct 12, 2019 at 7:31 PM Simon Marchi <simon.marchi@polymtl.ca> wrote:
>
> On 2019-10-12 01:05, cbiesinger@chromium.org wrote:
> > From: Christian Biesinger <cbiesinger@google.com>
> >
> > This variable is declared in tracepoint.h, which is already included
> > by remote.c.
>
> Remote -> Remove in the title.
>
> Otherwise, that LGTM.
Thanks, pushed.
Christian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-12 23:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-12 5:06 [PATCH] Remote unnecessary declaration of trace_regblock_size cbiesinger
2019-10-12 23:31 ` Simon Marchi
2019-10-12 23:37 ` Christian Biesinger via gdb-patches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).