From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Pedro Alves <palves@redhat.com>
Cc: Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3] Make GDB compile with Python 3 on MinGW
Date: Thu, 15 Aug 2019 18:50:00 -0000 [thread overview]
Message-ID: <CAPTJ0XF81N_geY+L5XieEgbdf_G=f7LfXvm3ukRx=sH6CRwc0Q@mail.gmail.com> (raw)
In-Reply-To: <aafd8beb-1dd0-5131-b596-6532f3771c87@redhat.com>
Thanks, will send a patch in a second with that fixed (and which
undoes the WIN32 ifdef change I accidentally had in the last version)
Christian
On Thu, Aug 15, 2019 at 1:02 PM Pedro Alves <palves@redhat.com> wrote:
>
> On 8/15/19 6:42 PM, Christian Biesinger via gdb-patches wrote:
> > + error (_("Installation error: gdb._execute_file function is missing"));
> > + return;
>
> That "return" statement is dead code, error throws an exception.
>
> Thanks,
> Pedro Alves
next prev parent reply other threads:[~2019-08-15 18:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 0:05 [PATCH] " Christian Biesinger via gdb-patches
2019-08-14 16:06 ` [PATCH v2] " Christian Biesinger via gdb-patches
2019-08-15 2:58 ` Simon Marchi
2019-08-15 17:15 ` Christian Biesinger via gdb-patches
2019-08-15 17:15 ` [PATCH] " Christian Biesinger via gdb-patches
2019-08-15 17:42 ` [PATCH v3] " Christian Biesinger via gdb-patches
2019-08-15 18:02 ` Pedro Alves
2019-08-15 18:50 ` Christian Biesinger via gdb-patches [this message]
2019-08-15 18:49 ` [PATCH v4] " Christian Biesinger via gdb-patches
2019-08-22 20:48 ` [PING] " Christian Biesinger via gdb-patches
2019-08-22 22:24 ` Simon Marchi
2019-08-22 22:48 ` Christian Biesinger via gdb-patches
2019-09-14 13:09 ` Christian Biesinger via gdb-patches
2019-09-14 13:30 ` Eli Zaretskii
2019-09-14 20:43 ` [PATCH] Add a NEWS entry that gdb can be compiled with py3 on Windows Christian Biesinger via gdb-patches
2019-09-15 2:34 ` Eli Zaretskii
2019-09-15 2:42 ` Christian Biesinger via gdb-patches
2019-08-15 18:25 ` [PATCH v2] Make GDB compile with Python 3 on MinGW Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XF81N_geY+L5XieEgbdf_G=f7LfXvm3ukRx=sH6CRwc0Q@mail.gmail.com' \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).