From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84454 invoked by alias); 20 Sep 2019 02:59:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84350 invoked by uid 89); 20 Sep 2019 02:59:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-30.8 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1545 X-HELO: mail-ot1-f49.google.com Received: from mail-ot1-f49.google.com (HELO mail-ot1-f49.google.com) (209.85.210.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Sep 2019 02:59:11 +0000 Received: by mail-ot1-f49.google.com with SMTP id b2so4959177otq.10 for ; Thu, 19 Sep 2019 19:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Ec0XN1GE4BdDW0ZcuVjD8c2lKvOQlr9w+yF7EgxJEhA=; b=PaHRW3UxwwFAVxGfjebSn88vGH5zP6UOsWs3P4HZ5aHyD47aReKTD2UT8QMbMHkx8x vEOPJjkQqlZgFEhDMXKoE8CW4qcxZzkpEm+fmyeODWBRrAi9QkgOIokVvd6lZRUhUjBW sfwHkr+PrXgbE8JEWnoBOkivkZSW36ZLEyKW4+iytaQ8SEuyX4lEPXYcHGNcmMshGEfT Jp3Q10ku7fylmm3jEpK80L1+e9kAoptwtdhYzgNMloTBRq0A26vhW3YxnnaKV+Tp5jjR SHAwDnIVz3VvORRsnJZbCfPk3tahlUT7HeIWMjylqx3/Zb0w8aKiHP1Nbwdl2epLd6Pf 54FA== MIME-Version: 1.0 References: <20190920025733.42046-1-cbiesinger@google.com> In-Reply-To: <20190920025733.42046-1-cbiesinger@google.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Fri, 20 Sep 2019 02:59:00 -0000 Message-ID: Subject: Re: [PUSHED/OBVIOUS] Don't duplicate comment in symfile.c and .h To: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00396.txt.bz2 argh, accidentally sent the wrong file. please disregard (this is a duplicate) On Fri, Sep 20, 2019 at 11:57 AM Christian Biesinger wrote: > > This just replaces the comment in the .c file with > "See symfile.h.". > > gdb/ChangeLog: > > 2019-09-16 Christian Biesinger > > * symfile.c (auto_solib_add): Replace comment with a reference > to the header file. > --- > gdb/symfile.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/gdb/symfile.c b/gdb/symfile.c > index 3cd514409b..259a30aa04 100644 > --- a/gdb/symfile.c > +++ b/gdb/symfile.c > @@ -141,15 +141,7 @@ static const char *print_symbol_loading_enums[] = > }; > static const char *print_symbol_loading = print_symbol_loading_full; > > -/* If non-zero, shared library symbols will be added automatically > - when the inferior is created, new libraries are loaded, or when > - attaching to the inferior. This is almost always what users will > - want to have happen; but for very large programs, the startup time > - will be excessive, and so if this is a problem, the user can clear > - this flag and then add the shared library symbols as needed. Note > - that there is a potential for confusion, since if the shared > - library symbols are not loaded, commands like "info fun" will *not* > - report all the functions that are actually present. */ > +/* See symfile.h. */ > > int auto_solib_add = 1; > > -- > 2.23.0.237.gc6a4ce50a0-goog >