From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cbiesinger@google.com>
Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com
 [IPv6:2a00:1450:4864:20::32b])
 by sourceware.org (Postfix) with ESMTPS id DF9CC3851C36
 for <gdb-patches@sourceware.org>; Fri, 12 Jun 2020 18:19:49 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DF9CC3851C36
Received: by mail-wm1-x32b.google.com with SMTP id l17so9012511wmj.0
 for <gdb-patches@sourceware.org>; Fri, 12 Jun 2020 11:19:49 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=MXLhJN5iZNo9LSlbk2KGi/i+qDo8ggEG0M5CFmi+0IA=;
 b=ImPavEENJ7CAoPwwYHYaMPLh9I4gaqPaPpnesW0qQfyTJ9IuzIKS3Bj5TMZHhOXyuL
 STGUVL5k0hkSGXgpCYbWEKDnMKDT4gkgWtl9+TD5z7hVwCEzICty68xhiSDDzBGCRzqk
 8H2vFlM879aFVsEOVsvcVFNoWLsbGD84LjkggoPbULDcf1paI2ofU3rP7jQUzBEedNOJ
 3n/ol0QHg+Xu8yJEADXsgy5AoVFfhxaDdxWpJ446oBDiu2zOBplcwSTevlmXFIHoxleZ
 6W0qVfTmPHX+JMecPTZ1Pdj3bZibYC7V+llFFQmluLmITAi08OUyYZRf38xGvAuA+Jte
 LQmw==
X-Gm-Message-State: AOAM531nPjqMHfAQX/bh5sm22CRaCZsuPxh/7pBDmkZ6SNTw0omBXHss
 +ZBdx/mEkySTspr76k0kL3P8XPpAYRurQEbBV3yOyw==
X-Google-Smtp-Source: ABdhPJww9yDTe+EJmGsuEiB5dN4SJ/kVxEufqdPvyE4sZM3JyEVMXMaZsRDHJaZx1HQclTPBFPP6Q42RmzHRkL1eD+8=
X-Received: by 2002:a1c:1b11:: with SMTP id b17mr171937wmb.123.1591985988681; 
 Fri, 12 Jun 2020 11:19:48 -0700 (PDT)
MIME-Version: 1.0
References: <20200612163715.GA21612@delia>
In-Reply-To: <20200612163715.GA21612@delia>
From: Christian Biesinger <cbiesinger@google.com>
Date: Fri, 12 Jun 2020 13:19:11 -0500
Message-ID: <CAPTJ0XFGUFJ33UOt+9sBqJH_QmzcXfcky72Ty7kaVN8XBLbT7g@mail.gmail.com>
Subject: Re: [committed][gdbserver] Fix Wlto-type-mismatch for debug_agent
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-18.0 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jun 2020 18:19:51 -0000

On Fri, Jun 12, 2020 at 11:37 AM Tom de Vries <tdevries@suse.de> wrote:
>
> Hi,
>
> When building gdb including gdbserver with CFLAGS/CXXFLAGS -O2 -g -flto=auto,
> I run into:
> ...
> src/gdbserver/../gdbsupport/agent.h:47:13: error: type of 'debug_agent' \
>   does not match original declaration [-Werror=lto-type-mismatch]
>  extern bool debug_agent;
>              ^
> src/gdbserver/ax.cc:28:5: note: type 'int' should match type 'bool'
>  int debug_agent = 0;
>      ^
> src/gdbserver/ax.cc:28:5: note: 'debug_agent' was previously declared here
> src/gdbserver/ax.cc:28:5: note: code may be misoptimized unless \
>   -fno-strict-aliasing is used

So it sounds like this didn't come up before because ax.cc doesn't
include gdbsupport/agent.h? It probably should?

Christian