* [PATCH] Move declaration of varobjdebug to header
@ 2019-10-10 4:08 cbiesinger
2019-10-10 12:56 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: cbiesinger @ 2019-10-10 4:08 UTC (permalink / raw)
To: gdb-patches; +Cc: Christian Biesinger
From: Christian Biesinger <cbiesinger@google.com>
gdb/ChangeLog:
2019-10-09 Christian Biesinger <cbiesinger@google.com>
* mi/mi-cmd-var.c (varobjdebug): Remove declaration.
* varobj.c (varobjdebug): Move comment to...
* varobj.h (varobjdebug): ...here, and declare.
---
gdb/mi/mi-cmd-var.c | 2 --
gdb/varobj.c | 2 +-
gdb/varobj.h | 5 +++++
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/gdb/mi/mi-cmd-var.c b/gdb/mi/mi-cmd-var.c
index f5219e0f9b2..d1de382af77 100644
--- a/gdb/mi/mi-cmd-var.c
+++ b/gdb/mi/mi-cmd-var.c
@@ -33,8 +33,6 @@
#include "gdbsupport/gdb_optional.h"
#include "inferior.h"
-extern unsigned int varobjdebug; /* defined in varobj.c. */
-
static void varobj_update_one (struct varobj *var,
enum print_values print_values,
bool is_explicit);
diff --git a/gdb/varobj.c b/gdb/varobj.c
index 809006827f2..827a1b0c0f0 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -40,7 +40,7 @@
typedef int PyObject;
#endif
-/* Non-zero if we want to see trace of varobj level stuff. */
+/* See varobj.h. */
unsigned int varobjdebug = 0;
static void
diff --git a/gdb/varobj.h b/gdb/varobj.h
index 9067d2d6beb..8f00d780d47 100644
--- a/gdb/varobj.h
+++ b/gdb/varobj.h
@@ -235,6 +235,11 @@ extern const struct lang_varobj_ops cplus_varobj_ops;
extern const struct lang_varobj_ops ada_varobj_ops;
#define default_varobj_ops c_varobj_ops
+
+/* Non-zero if we want to see trace of varobj level stuff. */
+
+extern unsigned int varobjdebug;
+
/* API functions */
extern struct varobj *varobj_create (const char *objname,
--
2.23.0.581.g78d2f28ef7-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Move declaration of varobjdebug to header
2019-10-10 4:08 [PATCH] Move declaration of varobjdebug to header cbiesinger
@ 2019-10-10 12:56 ` Tom Tromey
2019-10-10 17:41 ` Christian Biesinger via gdb-patches
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2019-10-10 12:56 UTC (permalink / raw)
To: cbiesinger; +Cc: gdb-patches, Christian Biesinger
>>>>> "cbiesinger" == cbiesinger <cbiesinger@chromium.org> writes:
> 2019-10-09 Christian Biesinger <cbiesinger@google.com>
> * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
> * varobj.c (varobjdebug): Move comment to...
> * varobj.h (varobjdebug): ...here, and declare.
Ok, thanks.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Move declaration of varobjdebug to header
2019-10-10 12:56 ` Tom Tromey
@ 2019-10-10 17:41 ` Christian Biesinger via gdb-patches
0 siblings, 0 replies; 3+ messages in thread
From: Christian Biesinger via gdb-patches @ 2019-10-10 17:41 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On Thu, Oct 10, 2019 at 7:56 AM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "cbiesinger" == cbiesinger <cbiesinger@chromium.org> writes:
>
> > 2019-10-09 Christian Biesinger <cbiesinger@google.com>
>
> > * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
> > * varobj.c (varobjdebug): Move comment to...
> > * varobj.h (varobjdebug): ...here, and declare.
>
> Ok, thanks.
Thanks, pushed.
To ssh://sourceware.org/git/binutils-gdb.git
6dfc0041129..c2c440a9038 HEAD -> master
Christian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-10 17:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-10 4:08 [PATCH] Move declaration of varobjdebug to header cbiesinger
2019-10-10 12:56 ` Tom Tromey
2019-10-10 17:41 ` Christian Biesinger via gdb-patches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).