From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Include gdbtk.h to avoid declarations
Date: Thu, 10 Oct 2019 17:44:00 -0000 [thread overview]
Message-ID: <CAPTJ0XFrG0zoPCW=hCBMN2jR-1GaLfrhPEvyqYuZtX5ekp0wAQ@mail.gmail.com> (raw)
In-Reply-To: <87ftk3gz51.fsf@tromey.com>
On Tue, Oct 8, 2019 at 8:11 AM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> From: Christian Biesinger <cbiesinger@chromium.org>
> Christian> Once https://sourceware.org/ml/insight/2019-q4/msg00000.html lands,
> Christian> we can just include gdbtk.h to get the declarations for
> Christian> external_editor_command and gdbtk_test, instead of having to
> Christian> declare them here in main.c.
>
> Christian> gdb/ChangeLog:
>
> Christian> 2019-10-07 Christian Biesinger <cbiesinger@chromium.org>
>
> Christian> * main.c (captured_main_1): Include gdbtk.h and remove declarations
> Christian> for external_editor_command and gdbtk_test.
>
> Looks good to me, thanks.
Thanks, pushed now that the change to insight landed.
To ssh://sourceware.org/git/binutils-gdb.git
c2c440a9038..26344e0c532 HEAD -> master
Christian
prev parent reply other threads:[~2019-10-10 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 21:22 Christian Biesinger via gdb-patches
2019-10-08 13:12 ` Tom Tromey
2019-10-10 17:44 ` Christian Biesinger via gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XFrG0zoPCW=hCBMN2jR-1GaLfrhPEvyqYuZtX5ekp0wAQ@mail.gmail.com' \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).