From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85540 invoked by alias); 27 Nov 2019 17:10:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85531 invoked by uid 89); 27 Nov 2019 17:10:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-29.1 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=ssh X-HELO: mail-oi1-f195.google.com Received: from mail-oi1-f195.google.com (HELO mail-oi1-f195.google.com) (209.85.167.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 17:10:52 +0000 Received: by mail-oi1-f195.google.com with SMTP id j7so20778402oib.3 for ; Wed, 27 Nov 2019 09:10:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WcqmnWlhVj9KHjPKplIKhVNNnVQK39zzREL75cb9djo=; b=HVIMdUgmyPcWjD7NCZR86Sn5/u/VKGr9ItJ675Jg/uOgUhiy4Y/2G9cHnYxD1epyu2 yLeL7AkcCCpul2DVXQCT/3Hb1Ad6RdTdbj9XcuGFJ86+zr3f+MsMDW/8dTIjX+AibUkA XJ8CyDd2tYa9o6O7QA6pPyrvZhqt6/ZZ+KdH2PzwNm2hnMvCIW9hGza8D9ooldvJbsCJ aoRLAQi6Q02RKTu+XQlVNlACxBcFujjD2198GIGTONBDd20nzq3cjEuC2LS1Xq4OtJON XbCAAXYqumRuE6piJh/hyerI2L+W9ardOeF0j3fhfPyRhVq5NI1pcI6DAr01M78t3qDr 4mdw== MIME-Version: 1.0 References: <20191126204351.83076-1-cbiesinger@google.com> <38f6c8b4-25d7-b116-9fe1-b87dfc393b5d@simark.ca> In-Reply-To: <38f6c8b4-25d7-b116-9fe1-b87dfc393b5d@simark.ca> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Wed, 27 Nov 2019 17:10:00 -0000 Message-ID: Subject: Re: [PATCH] Replace SYMBOL_SET_LINKAGE_NAME with a member function To: Simon Marchi Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg01046.txt.bz2 On Tue, Nov 26, 2019 at 9:54 PM Simon Marchi wrote: > > On 2019-11-26 3:43 p.m., Christian Biesinger via gdb-patches wrote: > > Easier to read, shorter, and will later make it possible to make the > > name field private. > > Thanks, LGTM, with the nits below fixed. Thanks for catching those, not sure how that happened. Fixed and pushed: To ssh://sourceware.org/git/binutils-gdb.git db5960b4d2..43678b0afe HEAD -> master > > diff --git a/gdb/stabsread.c b/gdb/stabsread.c > > index 6ec9f971e1..3f3f0a624f 100644 > > --- a/gdb/stabsread.c > > +++ b/gdb/stabsread.c > > @@ -399,8 +399,7 @@ patch_block_stabs (struct pending *symbols, struct pending_stabs *stabs, > > /* for all the stab entries, find their corresponding symbols and > > patch their types! */ > > > > - for (ii = 0; ii < stabs->count; ++ii) > > - { > > + for (ii = 0; ii < stabs->count; ++ii) { > > Unrelated change. Done. > > diff --git a/gdb/symtab.h b/gdb/symtab.h > > index 897ffda76e..ff51069b6c 100644 > > --- a/gdb/symtab.h > > +++ b/gdb/symtab.h > > @@ -407,8 +407,7 @@ struct general_symbol_info > > > > /* Return the demangled name for a symbol based on the language for > > that symbol. If no demangled name exists, return NULL. */ > > - const char *demangled_name () const; > > - > > + const char *demangled_name () const; > > Unrelated change. Done. Christian