From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by sourceware.org (Postfix) with ESMTPS id 631083858D37 for ; Mon, 6 Jul 2020 18:20:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 631083858D37 Received: by mail-qk1-x741.google.com with SMTP id k18so35718365qke.4 for ; Mon, 06 Jul 2020 11:20:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z1GtUUFV2Rfy6xd6QpCdfkjPgvxsATikr61R3u2oMfY=; b=okRhv8cdPaxqaRw2GvueqmxkWFcxGA/dJFi658B60KGUA8uZLK6O0pTBXxsNncceQu 3aup9A1RSGEagkQ7zzAnDntLuSOK7epe6sPXYxWQ2pXz/5RrprV8z21AXEr2DNFyCBT7 TloAY6XnI0LOMgoFtquUOHSxYra3cFVhZcpDifuGQJ9/8n3rtnmoNutLtX2aEWA3BlLG 4uTRZiu9iUm2SGczRVw46lNaE1YeGjr/rdJRd6g1gSFjgzTLWZ72OuNMJhkdpqn8Hj7x tJp8iktywvVFdH3L6bxqLAzjSW+HW2t5qORRCfKxZAHIXjn4iYxaXpIoXWKdy1JxZ6gH 4IWw== X-Gm-Message-State: AOAM5318bNP0q87s+DCjiJSCXJ9zNV6a3IWW9BO6pMXCa4L8mH421Zfw k/24govv0iTC6c0LNC5JCaxGfts3XTsGWnUcdm7kQy7x88w= X-Google-Smtp-Source: ABdhPJxaYEAXd3k4vqBBCZBdKsnFKsxgPPI2WaL2k38Lrte3aHBqdBZN2QdnyQsB4FMLmQkWvu5K/3poMpiv0yIqrUM= X-Received: by 2002:a37:6503:: with SMTP id z3mr46318955qkb.439.1594059608626; Mon, 06 Jul 2020 11:20:08 -0700 (PDT) MIME-Version: 1.0 References: <20200630184349.4009048-1-cbiesinger@google.com> <83h7upwxjl.fsf@gnu.org> <2d285f8f-57be-2d4f-ce7f-57afe65c6898@palves.net> In-Reply-To: <2d285f8f-57be-2d4f-ce7f-57afe65c6898@palves.net> From: Christian Biesinger Date: Mon, 6 Jul 2020 13:19:32 -0500 Message-ID: Subject: Re: [PATCH] Update gnulib to current trunk To: Pedro Alves Cc: Eli Zaretskii , gdb-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jul 2020 18:20:10 -0000 Fair enough. This is the module diff: --- /tmp/old 2020-07-06 13:04:17.837482577 -0500 +++ /tmp/new 2020-07-06 13:02:48.636984706 -0500 @@ -1,9 +1,12 @@ +Module list with included dependencies (indented): absolute-header alloca alloca-opt arpa_inet assure at-internal + attribute + btowc builtin-expect c99 canonicalize-lgpl @@ -13,12 +16,12 @@ close closedir count-one-bits + ctype d-ino d-type dirent dirfd dirname-lgpl - dosname double-slash-root dup dup2 @@ -52,8 +55,8 @@ getdtablesize getlogin_r getprogname + getrandom gettext-h - gettimeofday glob glob-h hard-locale @@ -62,6 +65,7 @@ intprops inttypes inttypes-incomplete + isblank isnand-nolibm isnanl-nolibm largefile @@ -69,7 +73,6 @@ limits-h localcharset locale - localtime-buffer lock lstat malloc-posix @@ -78,11 +81,13 @@ mbrtowc mbsinit mbsrtowcs + mbtowc memchr memmem memmem-simple mempcpy memrchr + minmax mkdir mkdtemp mkostemp @@ -132,13 +137,14 @@ strerror-override strerror_r-posix string + strnlen strnlen1 strstr strstr-simple strtok_r + sys_random sys_socket sys_stat - sys_time sys_types sys_uio tempname @@ -156,5 +162,7 @@ windows-once windows-recmutex windows-rwlock + wmemchr + wmempcpy xalloc-oversized It seems what is getting removed is: - dosname (deprecated module and we don't use dosname.h) - gettimeofday (it looks like we use this in remote-fileio.c) - localtime-buffer (looks like basically an implementation detail) - sys_time (looks like GDB specifically did *not* want this per comments in gdbsupport/gdb_sys_time.h) So: - For gettimeofday, the fixes in https://www.gnu.org/software/gnulib/manual/html_node/gettimeofday.html#gettimeofday don't look that important for gdb, but we could include the module. Let me know if you want me to. - For sys_time, we could perhaps replace the #undef in gdb_sys_time.h with an #error. Let me know. Christian On Thu, Jul 2, 2020 at 2:07 PM Pedro Alves wrote: > > On 7/2/20 8:02 PM, Eli Zaretskii wrote: > >> From: Pedro Alves > >> Date: Thu, 2 Jul 2020 19:49:53 +0100 > >> > >>> This fixes two issues on Windows: Update. > >>> https://sourceware.org/pipermail/gdb-patches/2020-June/169978.html > >> > >> This seems to be bringing in a good amount of churn. > > > > Maybe we should just update the two modules which were changed due to > > my reports? Would that be safer? > > > > I don't know. I'd be happy with just seeing the list of the > dependencies being pulled in and dropped before making such > a decision. It's just a precautionary measure, the update is > probably fine. > > Pedro Alves