Re: [PATCH 1/4] gdb: add intern method to objfile_per_bfd_storage

[Christian Biesinger <cbiesinger@google.com>]

On Mon, Mar 22, 2021 at 8:34 PM Simon Marchi via Gdb-patches
<gdb-patches@sourceware.org> wrote:
>
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> This allows factoring out the internal implementation details that are
> currently in the two objfile::intern methods.
>
> gdb/ChangeLog:
>
>         * objfiles.h (struct objfile_per_bfd_storage) <intern>: New
>         method.
>         (struct objfile) <intern>: Use
>         objfile::objfile_per_bfd_storage::intern.
>
> Change-Id: Ifd54026c5efaeffafac9b84ff84c199acc7ce78a
> ---
>  gdb/objfiles.h | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/gdb/objfiles.h b/gdb/objfiles.h
> index 41f8fc913d8..d9aa06636f5 100644
> --- a/gdb/objfiles.h
> +++ b/gdb/objfiles.h
> @@ -270,6 +270,14 @@ struct objfile_per_bfd_storage
>
>    ~objfile_per_bfd_storage ();
>
> +  /* Intern STRING in this object's string cache and return the unique copy.
> +     The copy has the same lifetime as this object.  */
> +
> +  const char *intern (gdb::string_view str)
> +  {
> +    return (const char *) string_cache.insert (str.data (), str.size () + 1);

Is this guaranteed to be nullterminated even without calling c_str()?

Christian