From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by sourceware.org (Postfix) with ESMTPS id 34C04385C426 for ; Sat, 23 May 2020 18:59:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 34C04385C426 Received: by mail-qk1-x744.google.com with SMTP id f189so14079899qkd.5 for ; Sat, 23 May 2020 11:59:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AymtVbDGkChvMU/m2XaD9atB6pHcbkRZwZtvPJVQFtw=; b=NZhN8rynXvDNg7f/ouItaRMQJq437YF0fyTadg5u4SiKG1L27DRVTdJX3bcVeP9hq2 yaA0fVqkqQauhYu3JK1Uz3rA/IVBZkLADhVAYmgB6sxqHjSv2APpxFjEpuzFIBpC4HKW sZWlteelc4Fu56fbhFT4z+CZBJBunTet/ZLVOtG3AV1Q0g3O4KDn1mTveQ8WZU2tuSJ1 ooLe02IL0WAEfFNcCSbqgwdLTGRLhaH/Pkyd3yzhkifhULpEkHt+UlPzkgmUHmwI3s4/ Lt9ssCAKtr9VC9m7DJ6FXCvLsQhRYzCvV8Ck7rPFcF5vElN/Y1oQlP3Q6MKjwncW5v6G fG7A== X-Gm-Message-State: AOAM533KGS5JQlx/S4cCFVS0dZ1OzZ12v8BrnZsIj+tCvkApTzyBKdOf c/XX4RQEuvjbaJ8gUZ1i1tFOBM14Y+vXm5KjKGT9ng== X-Google-Smtp-Source: ABdhPJxMYB1vc7RYWiXoRMg2cVP4j3Ym3c6fFnJybO2X/qwd0ofzEOXf3pmJb45S+CiurP1dW27vcu/X8eJOgk0EjHI= X-Received: by 2002:a37:6253:: with SMTP id w80mr19584267qkb.132.1590260347318; Sat, 23 May 2020 11:59:07 -0700 (PDT) MIME-Version: 1.0 References: <20200205175257.197506-1-cbiesinger@google.com> <20200523163130.GA2122@adacore.com> In-Reply-To: <20200523163130.GA2122@adacore.com> From: Christian Biesinger Date: Sat, 23 May 2020 13:58:55 -0500 Message-ID: Subject: Re: Pushed to gdb-9-branch: [PUSHED/OBVIOUS] Fix base class function call To: Joel Brobecker Cc: Christian Biesinger via gdb-patches , Simon Marchi X-Spam-Status: No, score=-26.4 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 May 2020 18:59:11 -0000 On Sat, May 23, 2020, 11:31 Joel Brobecker wrote: > Hi Christian (and Simon), > > On Wed, Feb 05, 2020 at 11:52:57AM -0600, Christian Biesinger via > gdb-patches wrote: > > This was a typo introduced in f6ac5f3d63e03a81c4ff3749aba234961cc9090e. > > > > Found by looking through NetBSD's GDB patches: > > > https://github.com/NetBSD/pkgsrc-wip/blob/master/gdb-netbsd/patches/patch-gdb_sparc-nat.h > > > > This patch can't be tested on Linux because Linux does not use the > > sparc_target template. > > > > gdb/ChangeLog: > > > > 2020-02-05 Christian Biesinger > > > > * sparc-nat.h (struct sparc_target) : Fix base class > > function call. > > As a user stumbled onto the error that this commit fixes, and the > correction > is indeed quite obvious, I created a new PR for this issue, and then > backported the patch to the gdb-9-branch: > > https://sourceware.org/bugzilla/show_bug.cgi?id=26029 Thanks Joel! I had completely forgotten that I wrote that patch. > > > > Change-Id: I4fa88cbdc365efe89b84cc0619b60db38718d9ce > > --- > > gdb/sparc-nat.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/gdb/sparc-nat.h b/gdb/sparc-nat.h > > index 1dbdd80b5e..d07bd86d03 100644 > > --- a/gdb/sparc-nat.h > > +++ b/gdb/sparc-nat.h > > @@ -75,8 +75,8 @@ struct sparc_target : public BaseTarget > > return sparc_xfer_wcookie (object, annex, readbuf, writebuf, > > offset, len, xfered_len); > > > > - return BaseTarget (object, annex, readbuf, writebuf, > > - offset, len, xfered_len); > > + return BaseTarget::xfer_partial (object, annex, readbuf, writebuf, > > + offset, len, xfered_len); > > } > > }; > > > > -- > > 2.25.0.341.g760bfbb309-goog > > -- > Joel >