From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cbiesinger@google.com>
Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com
 [IPv6:2607:f8b0:4864:20::729])
 by sourceware.org (Postfix) with ESMTPS id A0EA9385DC0A
 for <gdb-patches@sourceware.org>; Fri,  5 Jun 2020 18:27:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A0EA9385DC0A
Received: by mail-qk1-x729.google.com with SMTP id n141so10716671qke.2
 for <gdb-patches@sourceware.org>; Fri, 05 Jun 2020 11:27:13 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=hvOrAPoCtc4U9aJQhNeTeaFB+7TtEKFDXKxd+JnR8FY=;
 b=HYUcsD6oFQcKflPNbt+tgpXZB5zrPxWiWjUtu5JgH9uhOS/IhqmS91RiNjVvu7VqS9
 PufP0BhilLhidxQzG3tsKs193WTwHXQDyRusyKZoFpGZcSjPqWNimiTsrBgiOJCch6tr
 Jlx8SWHUrtBtdmBWCLW2vmP7tW+rjUw9rimyXC/V6KjC1coHpT+YIGeqWD2gcO3cdw/A
 0rRxl7JyA495PnA6dSDU4U2c8xWqetugNJNV9I4tALWbY3WHoAFN4Dn2kD6UVHhvCK5h
 Of6MsjpsSuJoURWi87nBjoEPP2/39eK5sKvJxtaqZ7YgcBx9ZqV/5s2C2JvFSTEMCaxb
 /Mrw==
X-Gm-Message-State: AOAM532/1mFFdPg2xapx22u8j0GwcEWOo6BeWHujgfxOP2HIO1z5/ptT
 hk0PZ/sKjVU/p6nx67lyxUQ++bQwv/rfdBBbgE2Pjjlw
X-Google-Smtp-Source: ABdhPJwunjuF1UFZv3GNS15RMKRR24+ufvujw3/4TnPPWvcHXsdy28ZzVTzIHvPidbFgM2LJzNhN0XoCN76cGK/ZNmI=
X-Received: by 2002:a05:620a:68a:: with SMTP id
 f10mr11164364qkh.419.1591381632779; 
 Fri, 05 Jun 2020 11:27:12 -0700 (PDT)
MIME-Version: 1.0
References: <20200605182337.981585-1-andrew.burgess@embecosm.com>
In-Reply-To: <20200605182337.981585-1-andrew.burgess@embecosm.com>
From: Christian Biesinger <cbiesinger@google.com>
Date: Fri, 5 Jun 2020 13:26:36 -0500
Message-ID: <CAPTJ0XGYggkTxya84ToEhdPJmA5w-_SJFpzbN8nsxdyYXETxyQ@mail.gmail.com>
Subject: Re: [PUSHED] gdb/python: Avoid use after free in py-tui.c
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-19.9 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jun 2020 18:27:14 -0000

On Fri, Jun 5, 2020 at 1:23 PM Andrew Burgess
<andrew.burgess@embecosm.com> wrote:

> -  win->window->title = value.get ();
> +  win->window->title = value.release ();

Does the old title need to be freed here?

Christian