public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add an objfile getter to gdb.Type
Date: Thu, 23 May 2019 20:36:00 -0000	[thread overview]
Message-ID: <CAPTJ0XGcoLPuNAiKo550Tq8JOGqvB7UYA8na1sXZ5hphFurSRQ@mail.gmail.com> (raw)
In-Reply-To: <e130fe5f-70ed-7bb6-c909-ff9a5538de34@simark.ca>

On Thu, May 23, 2019 at 2:34 PM Simon Marchi <simark@simark.ca> wrote:
> > +/* Return the type's tag, or None.  */
>
> copy-pasto: "type's objfile"

Done

> > +static PyObject *
> > +typy_get_objfile (PyObject *self, void *closure)
> > +{
> > +  struct type *type = ((type_object *) self)->type;
> > +  struct objfile *objfile = nullptr;
> > +
> > +  objfile = TYPE_OBJFILE(type);
>
> You can write it as
>
>   struct objfile *objfile = objfile = TYPE_OBJFILE (type);
>
> directly.
>
> We would need a corresponding test though.  It should be a relatively easy addition
> to testsuite/gdb.python/py-type.exp.  See here for info about how to run just one
> test:

Done. I sent the updated patch as a separate email, I hope I did it right.

Thanks,
Christian

  reply	other threads:[~2019-05-23 20:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 18:40 Christian Biesinger via gdb-patches
2019-05-23 19:01 ` Eli Zaretskii
2019-05-23 19:34 ` Simon Marchi
2019-05-23 20:36   ` Christian Biesinger via gdb-patches [this message]
2019-05-23 20:32 ` Christian Biesinger via gdb-patches
2019-05-23 21:06   ` Simon Marchi
2019-05-23 21:25     ` Christian Biesinger via gdb-patches
2019-05-23 21:37   ` Christian Biesinger via gdb-patches
2019-05-28 22:07     ` Tom Tromey
2019-05-30 17:01       ` Christian Biesinger via gdb-patches
2019-06-03 19:50         ` Tom Tromey
2019-06-03 20:28           ` Christian Biesinger via gdb-patches
2019-06-04 15:47             ` Tom Tromey
2019-06-04 21:48               ` Pedro Alves
2019-06-04 22:07                 ` Christian Biesinger via gdb-patches
2019-06-05  1:51                   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPTJ0XGcoLPuNAiKo550Tq8JOGqvB7UYA8na1sXZ5hphFurSRQ@mail.gmail.com \
    --to=gdb-patches@sourceware.org \
    --cc=cbiesinger@google.com \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).