From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Pedro Alves <palves@redhat.com>
Cc: gnutoolchain-gerrit@osci.io, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [review v3] Use ctime_r and localtime_r if available
Date: Fri, 08 Nov 2019 17:11:00 -0000 [thread overview]
Message-ID: <CAPTJ0XGdf_C8ydMGN1Tae7kNUw+cSZhvvr_KP0GnjpSbjHC7OQ@mail.gmail.com> (raw)
In-Reply-To: <00713bff-8560-e51f-f193-8845af83251e@redhat.com>
On Fri, Nov 8, 2019 at 8:08 AM Pedro Alves <palves@redhat.com> wrote:
> And, note that localtime, like other C functions that use global
> state, are thread safe on Windows, because the C run time stores
> the global buffers in thread local storage. So the gnulib
> implementation ends up being thread safe there, even though
> it doesn't look like it is.
OK, I'll change this to use the time_r module.
I'll make it depend on
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514 since that
one also imports a new module.
Christian
next prev parent reply other threads:[~2019-11-08 17:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 21:06 [review] " Christian Biesinger (Code Review)
2019-10-31 21:15 ` Christian Biesinger (Code Review)
2019-11-03 2:54 ` [review v2] " Christian Biesinger (Code Review)
2019-11-03 7:20 ` Andreas Schwab
2019-11-03 20:09 ` Christian Biesinger via gdb-patches
2019-11-03 2:54 ` [review] " Christian Biesinger (Code Review)
2019-11-03 20:04 ` [review v3] " Christian Biesinger (Code Review)
2019-11-06 20:30 ` Christian Biesinger (Code Review)
2019-11-08 14:09 ` Pedro Alves
2019-11-08 17:11 ` Christian Biesinger via gdb-patches [this message]
2019-11-09 20:18 ` Christian Biesinger via gdb-patches
2019-11-10 7:38 ` Kevin Buettner (Code Review)
2019-11-10 7:45 ` Kevin Buettner (Code Review)
2019-11-11 22:22 ` [review v4] " Christian Biesinger (Code Review)
2019-11-11 22:27 ` [review v5] Use ctime_r and localtime_r for threadsafety Christian Biesinger (Code Review)
2019-11-11 22:29 ` Christian Biesinger (Code Review)
2019-11-12 20:21 ` Kevin Buettner (Code Review)
2019-11-15 19:50 ` [review v6] " Christian Biesinger (Code Review)
2019-11-15 19:52 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-16 22:07 ` [review v6] " Christian Biesinger (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTJ0XGdf_C8ydMGN1Tae7kNUw+cSZhvvr_KP0GnjpSbjHC7OQ@mail.gmail.com \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=gnutoolchain-gerrit@osci.io \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).