From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26670 invoked by alias); 26 Feb 2020 20:23:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26661 invoked by uid 89); 26 Feb 2020 20:23:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-29.4 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1119 X-HELO: mail-ot1-f65.google.com Received: from mail-ot1-f65.google.com (HELO mail-ot1-f65.google.com) (209.85.210.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Feb 2020 20:23:37 +0000 Received: by mail-ot1-f65.google.com with SMTP id h9so677565otj.11 for ; Wed, 26 Feb 2020 12:23:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ze9eYgyPVOFysVf71pdk60kV6QQq4dZ/qBq2w1o1ABE=; b=U5th4mcUXm58tJ1zY9PoRppQZH7jQ7NwQpiCQkomS4Xk5jpuzzbFxc3LRz91jobS2Y FrpFhDKUZinAu50tKYHfSCID943YnO2drVVX1ZZW8JEKY7pXrKjMnp/v7LzN7W7RnGDb eqDkvKaW6ebyp4rd0ySQqivdIvDXuVsobqtCaPEtAWzshRthTHcitvGxO+1M/g7ObHC1 ymHblRNkxJUK8sXefo83C+tt8rGPyeiL+N8weQlPbLzjy6T/LwFIrJkwBRNeSNqOBJ7p n0c7Yx+E7lwIJllDQ43vs5aevRb6DLWFsDaS1qsYqOrKdCWz2JAcfn23Gy34cnGE8meZ xkLA== MIME-Version: 1.0 References: <20190926042155.31481-1-sergiodj@redhat.com> <20200226200542.746617-1-sergiodj@redhat.com> <20200226200542.746617-7-sergiodj@redhat.com> In-Reply-To: <20200226200542.746617-7-sergiodj@redhat.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Wed, 26 Feb 2020 20:23:00 -0000 Message-ID: Subject: Re: [PATCH 6/6] Fix comment for 'gdb_dlopen' To: Sergio Durigan Junior Cc: GDB Patches , Pedro Alves , Tom Tromey , Eli Zaretskii , Ruslan Kabatsayev Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00994.txt.bz2 On Wed, Feb 26, 2020 at 2:06 PM Sergio Durigan Junior wrote: > > The 'gdb_dlopen' function doesn't return NULL if the shlib load > fails;n it actually throws an error. This patch updates the comment Typo here (;n) > to reflect this. > > gdbsupport/ChangeLog: > yyyy-mm-dd Sergio Durigan Junior > > * gdb-dlfcn.h (gdb_dlopen): Update comment. > --- > gdbsupport/gdb-dlfcn.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdbsupport/gdb-dlfcn.h b/gdbsupport/gdb-dlfcn.h > index 258cfebbc3..9e72a53dc0 100644 > --- a/gdbsupport/gdb-dlfcn.h > +++ b/gdbsupport/gdb-dlfcn.h > @@ -32,8 +32,8 @@ struct dlclose_deleter > typedef std::unique_ptr gdb_dlhandle_up; > > /* Load the dynamic library file named FILENAME, and return a handle > - for that dynamic library. Return NULL if the loading fails for any > - reason. */ > + for that dynamic library. Throw an error if the loading fails for > + any reason. */ > > gdb_dlhandle_up gdb_dlopen (const char *filename); > > -- > 2.24.1 >